-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python testing #1473
Python testing #1473
Conversation
e8030c9
to
6c58397
Compare
And, Travis finally passes. Attempting to install the Python dependencies via |
Awesome, looks good to me from my brief read through. This should definitely be merged before any other PyCaffe changes. |
Yup, I've watched that in agonizing pain while building a docker image. Can you post details of using miniconda? |
@tleyden: see the diff, which is based on https://gist.github.com/dan-blanchard/7045057 plus trial and error, and also this more official looking page: http://conda.pydata.org/docs/travis.html. |
Needs update from merge of #1472. |
@shelhamer rebased. |
Python testing
Python testing
Python testing
Python testing
Python testing
Python testing
To facilitate easier merging, I moved the bug fix that was here to #1228. |
Haha, oops, I was testing for that bug fix. I'll leave this as it is for now, and either #1228 will be merged and I'll rebase, or I'll push the fix to dev at some point and rebase, or something. |
Python testing
Python testing
Python testing
Python testing
Python testing
Make allows variable redefinition, so sed brittleness can be avoided.
Rebased after #1228 and passing again. |
After #1472.
This PR adds Python testing of very basic functionality.
unittest
module. We might want to consider other testing libraries (likenose
) in the future, but this is fine for now.make pytest
) and Travis._caffe
) is included so far. I'm going to go ahead and work on pycaffe on top of this, but BVLC folk are welcome to push more tests to this branch, and decide whether this should be merged right away (to at least have some testing) or a bit later (so that testing is not misleading by its paucity).