fixed from PVS-Studio #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V542 Consider inspecting an odd type cast: 'wchar_t *' to 'char *'. application.cpp 101 m_coeffs changed size to [SPLINE_POINTS][4]; V557 Array overrun is possible. The 'n' index is pointing beyond array bound. spline.h 27 V557 Array overrun is possible. The value of 'i' index could reach 15. spline.h 37 V557 Array overrun is possible. The value of 'j + 1' index could reach 15. spline.h 41 V557 Array overrun is possible. The value of 'j + 1' index could reach 15. spline.h 42 V557 Array overrun is possible. The 'ArcLengthIntegrandSingleSpline' function processes value '15'. Inspect the first argument. Check lines: 78, 92. spline.h 78 V575 The potential null pointer is passed into 'memset' function. Inspect the first argument. image_read.cpp 3495 V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present. spline.h 18 V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. tga.c 309 V773 The function was exited without releasing the 'hFind' handle. A resource leak is possible. platform_win32.cpp 166, 185V773 The function was exited without releasing the 'tga_data' pointer. A memory leak is possible. image_read.cpp 2970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a member of the Pinguem.ru competition on finding errors in open source projects. A bug, found using PVS-Studio. Warnings:
V542 Consider inspecting an odd type cast: 'wchar_t *' to 'char *'. application.cpp 101
m_coeffs changed size to [SPLINE_POINTS][4];
V557 Array overrun is possible. The 'n' index is pointing beyond array bound. spline.h 27
V557 Array overrun is possible. The value of 'i' index could reach 15. spline.h 37
V557 Array overrun is possible. The value of 'j + 1' index could reach 15. spline.h 41
V557 Array overrun is possible. The value of 'j + 1' index could reach 15. spline.h 42
V557 Array overrun is possible. The 'ArcLengthIntegrandSingleSpline' function processes value '15'. Inspect the first argument. Check lines: 78, 92. spline.h 78
V575 The potential null pointer is passed into 'memset' function. Inspect the first argument. image_read.cpp 3495
V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present. spline.h 18
V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. tga.c 309
V773 The function was exited without releasing the 'hFind' handle. A resource leak is possible. platform_win32.cpp 166, 185V773 The function was exited without releasing the 'tga_data' pointer. A memory leak is possible. image_read.cpp 2970