Conversation
|
I'll review this next week. |
As you told me in private you decided to be "tough" with me. |
|
OSX failure is not related to this particular PR. It should be fixed automatically with the next release of GitHub Actions OSX runner image. |
No. I told you that I'll never be as loyal to you as before and will treat you equally to any other contributor.
I didn't tell you this. I just told you that you should never delegate unfinished work to others and push your line.
I always give you the reason. Also, since I'm a maintainer, I always have the final word. And you have to deal with that.
This is only your opinion. I try to do best for this project.
If you'll act this way - you're right, no way.
This is my area of responsibility, and David trusts me here. |
AenBleidd
left a comment
There was a problem hiding this comment.
In general PR looks fine.
Please fix some minor comments
8babb9d to
78fe082
Compare
78fe082 to
f106111
Compare
|
LGTM. Thank you for the PR. |
Add snap build
Fix #4927
Fix #2485
Fix #4042
@davidpanderson Please review this PR.
Snap itself run inside core22 that it mean ubuntu 22.04 like.
Tested on online vm ubuntu 20.04. with gui and x11.