Remove std feature from rayon feature#476
Merged
oconnor663 merged 1 commit intoBLAKE3-team:masterfrom Apr 20, 2025
Merged
Conversation
Contributor
Author
|
cc @oconnor663, not sure if you're getting notifications about Rust changes without explicit pings |
Member
|
I think you're right on both counts. I don't think it's possible to pull in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found no good reason for
rayonfeature to requirestd. In fact it'd be nice to just userayonall the time sometimes regardless if it is used instdorno_stdenvironment.UPD: Looks like even
rayon-coredepends onstdinternally (which may or may not change in the future), but there is still no direct need for it in BLAKE3 itself.This complements #469