Skip to content

Remove std feature from rayon feature#476

Merged
oconnor663 merged 1 commit intoBLAKE3-team:masterfrom
nazar-pc:remove-std-from-rayon
Apr 20, 2025
Merged

Remove std feature from rayon feature#476
oconnor663 merged 1 commit intoBLAKE3-team:masterfrom
nazar-pc:remove-std-from-rayon

Conversation

@nazar-pc
Copy link
Copy Markdown
Contributor

@nazar-pc nazar-pc commented Apr 17, 2025

I found no good reason for rayon feature to require std. In fact it'd be nice to just use rayon all the time sometimes regardless if it is used in std or no_std environment.

UPD: Looks like even rayon-core depends on std internally (which may or may not change in the future), but there is still no direct need for it in BLAKE3 itself.

This complements #469

@nazar-pc
Copy link
Copy Markdown
Contributor Author

cc @oconnor663, not sure if you're getting notifications about Rust changes without explicit pings

@oconnor663
Copy link
Copy Markdown
Member

I think you're right on both counts. I don't think it's possible to pull in rayon without also pulling in std, but also there's no particularly reason we need to do this explicitly, and it's cleaner not to. Thanks!

@oconnor663 oconnor663 merged commit 21afc1a into BLAKE3-team:master Apr 20, 2025
64 checks passed
@nazar-pc nazar-pc deleted the remove-std-from-rayon branch May 20, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants