Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statement to identify start of section inputs to simplify statements for skipping unsupported sections #357

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 7, 2023

Issues addressed by this PR

Closes #356

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23356%20Custom%20Sections%20Not%20Supported?csf=1&web=1&e=OQFqUA

Changelog

  • Changed the way SectionProperties are read to capture unsupported sections from MidasCivil.
  • Improved the database searching when pulling database SectionProperty and IMaterialFragment from MidasCivil

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 7, 2023
@peterjamesnugent peterjamesnugent self-assigned this Sep 7, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

@FraserGreenroyd FraserGreenroyd force-pushed the MidasCivil_Toolkit-#356-AddWarningForCustomSectionsThatAreNotSupported branch from 819bb4b to 3fe2f6b Compare September 11, 2023 11:31
@jtrainor1
Copy link

Reviewed and works as intended:
image

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @peterjamesnugent offline, and approving for merge based on this review for testing via beta test artefacts this sprint.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 91ecb01 into develop Sep 11, 2023
10 checks passed
@FraserGreenroyd FraserGreenroyd deleted the MidasCivil_Toolkit-#356-AddWarningForCustomSectionsThatAreNotSupported branch September 11, 2023 17:18
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning for custom sections that are not supported
3 participants