Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raids cancelled outside of Island worlds #2291

Open
Srcsm opened this issue Dec 9, 2024 · 1 comment
Open

Raids cancelled outside of Island worlds #2291

Srcsm opened this issue Dec 9, 2024 · 1 comment
Assignees
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted

Comments

@Srcsm
Copy link

Srcsm commented Dec 9, 2024

Responding to a user on the discord, we noticed that raids are cancelled outside the islands world making using SSB on a server also trying to use a survival type world result in having raids being cancelled in the survival world.

image

if (island == null || island.isSpawn() || !island.isInside(location) || !island.isMember(superiorPlayer))

Ideally, it would be nice if there were a config setting perhaps to list the world(s) to allow/restrict raids on, that way raids can still be allowed on a survival type world on the same server as SSB when the player isn't inside an island world. Otherwise, an added island setting to enable/disable raids maybe would help achieve the same goal?

Originally posted by @Srcsm in #2290

Plugin version: SuperiorSkyblock2-2024.4-b368.jar
Server version: Paper version 1.21.1-128-master@d348cb8 (2024-10-21T16:23:24Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)

@OmerBenGera OmerBenGera added the ✔️ Confirmed Confirmed bugs that can be replicated label Dec 13, 2024
@OmerBenGera OmerBenGera self-assigned this Dec 13, 2024
@OmerBenGera OmerBenGera added the 🔧 Potential fix A potential fix was already submitted label Dec 13, 2024
@OmerBenGera
Copy link
Member

Check out latest dev build, let me know if it is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted
Projects
None yet
Development

No branches or pull requests

2 participants