WIP: Feature/Add_typehints and guarnieri stubs #1063
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prjemian
reviewed
Mar 27, 2025
prjemian
reviewed
Mar 27, 2025
| @@ -10,8 +10,9 @@ | |||
|
|
|||
| import datetime | |||
| import logging | |||
| import pathlib | |||
| from typing import Any, Dict, List, Optional, Union | |||
There was a problem hiding this comment.
Is there an advantage to use typing.Dict[str, str] when dict[str, str] passes linting and testing? Same for typing.List.
There was a problem hiding this comment.
I don't think there is any effect difference here. Here is why I started using typing as default:
https://stackoverflow.com/questions/37087457/difference-between-defining-typing-dict-and-dict
prjemian
reviewed
Mar 27, 2025
| _file_name = None | ||
| _file_path = None | ||
| file_extension: str = "dat" | ||
| _file_name: Optional[pathlib.Path] = None |
There was a problem hiding this comment.
For both of these, is Optional[Union[pathlib.Path,str]] acceptable? I think so. Check the unit testing to see if both ways are tested.
There was a problem hiding this comment.
Updated. Checking the tests soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.