-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty suites #56
Open
Sett17
wants to merge
5
commits into
BBE78:master
Choose a base branch
from
Sett17:skip-empty
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a console warning utility for better logging granularity.
…ort generation Skip the generation of SonarQube XML reports when the test suite contains zero tests, adhering to compliance standards that require test results to be present in the reports. This ensures no empty reports are created, which would not comply with the expected report structure.
BBE78
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sett17 for these changes, some small comments...
Refactoring to eliminate the redundant `totalTestCount` property in favor of checking the length of the `runner.suite.tests` array directly. This simplifies the logic for determining if the test suite is empty, making the codebase cleaner and easier to maintain.
Updated the console method in ReporterUtils to use `console.warn` for warning messages, ensuring the correct log level is used. Test suite descriptions were also standardized for consistency across test files, enhancing readability and maintainability of the test codebase.
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regards #55