Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WeldxFile doctest for asdf 3.0 #904

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

braingram
Copy link
Contributor

Changes

As mentioned in #903

A doctest is failing due to changes in asdf 3.0 (including removal of BuiltinExtension) that result in slight and otherwise inconsequential header differences.

This PR expands the use of ... in the doctest to allow the text matching to ignore these header differences.

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

Copy link

github-actions bot commented Jan 3, 2024

Test Results

2 188 tests  ±0   2 187 ✅ +1   2m 3s ⏱️ ±0s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌  - 1 

Results for commit da10598. ± Comparison against base commit bb213a7.

@marscher marscher added ASDF everything ASDF related (python + schemas) no-changelog-entry-needed tests pytest (and other tests) related labels Jan 4, 2024
@marscher
Copy link
Collaborator

marscher commented Jan 4, 2024

LGTM as well. I do not get, why the notebook tests for Python 3.10 fail with an ImportError for WeldxFile.

@braingram
Copy link
Contributor Author

That one is kind of puzzling.

I do see an error related to "quality_standard_demo":
https://github.com/BAMWelDX/weldx/actions/runs/7398732873/job/20179218430?pr=904#step:12:82

File ~/work/weldx/weldx/quality_standard_demo/src/quality_standard_demo/__init__.py:1
----> 1 from ._version import __version__

ModuleNotFoundError: No module named 'quality_standard_demo._version'

It looks like the cookiecutter template here: https://github.com/BAMWelDX/quality-standard-template
is rendered and installed:

cookiecutter --no-input https://github.com/BAMWeldx/quality-standard-template

but is lacking a _version file (perhaps something has changed in setuptools-scm that it's no longer generating a _version.py?).
The missing file appears to be preventing correct entry point loading for weldx which then leads to the ImportError for weldx.

@CagtayFabry
Copy link
Member

Thank you for the fix @braingram !

I haven't had time yet to look into the issue regarding the quality standard template I will try to follow up with what you already found

@CagtayFabry CagtayFabry self-requested a review January 5, 2024 08:21
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c94b182) 96.46% compared to head (da10598) 96.45%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.02%     
==========================================
  Files          95       95              
  Lines        6287     6287              
==========================================
- Hits         6065     6064       -1     
- Misses        222      223       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CagtayFabry
Copy link
Member

CagtayFabry commented Jan 5, 2024

I have updated the outdated build chain causing the issues BAMWelDX/quality-standard-template#20

Thanks again @braingram

@CagtayFabry CagtayFabry merged commit 66a9ce4 into BAMWelDX:master Jan 5, 2024
21 of 24 checks passed
@braingram braingram deleted the doctest_fix branch January 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) no-changelog-entry-needed tests pytest (and other tests) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants