Skip to content

Conversation

@Berger92
Copy link
Contributor

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Type issue fix for RuleDocsInfo

Fixes # (1146)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

  • TS Build errors relating to description field is gone (when strict flag is turned on)
  • No new TS Build errors

Test Environment:

  • OS: MacOS Monterey
  • @graphql-eslint/.3.11.2:
  • NodeJS: 16.16

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: 453d4c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Berger92 Berger92 mentioned this pull request Sep 27, 2022
4 tasks
@dimaMachina
Copy link
Contributor

Hey, thanks, I'll take care of this PR when I will enable strict: true in v4!

@dimaMachina dimaMachina added the status/parked This task has been temporarily parked - No work is currently underway label Oct 10, 2022
@dimaMachina dimaMachina removed the status/parked This task has been temporarily parked - No work is currently underway label Dec 28, 2022
@dimaMachina dimaMachina merged commit 876e536 into graphql-hive:master Dec 28, 2022
@Berger92 Berger92 deleted the ISSUE-1146 branch December 28, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants