Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize: new option groups #1144

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Alphabetize: new option groups #1144

merged 2 commits into from
Dec 20, 2022

Conversation

TuvalSimha
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 258e33a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TuvalSimha TuvalSimha marked this pull request as ready for review August 28, 2022 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-eslint/eslint-plugin 3.14.0-alpha-20221220195106-78926c0 npm ↗︎ unpkg ↗︎

@TuvalSimha TuvalSimha changed the title Alphabetize: startsWith + endsWith - DRAFT Alphabetize: startsWith + endsWith Aug 28, 2022
@TuvalSimha TuvalSimha changed the title Alphabetize: startsWith + endsWith Alphabetize: ignorePrefix + ignoreSuffix Aug 28, 2022
@dotansimha dotansimha linked an issue Sep 29, 2022 that may be closed by this pull request
Fix

Fix alphabetize rule

changeset

Fix

remove console error
@dimaMachina dimaMachina changed the title Alphabetize: ignorePrefix + ignoreSuffix Alphabetize: new option groups Dec 20, 2022
@iamandrewluca
Copy link

iamandrewluca commented Jun 14, 2024

Hey there! Thanks for this tremendous ESLint plugin!

I wanted to check if this should be the default behavior of the alphabetization?!

I have a feeling that groups: ['id', '*', 'createdAt', 'updatedAt'] is interpreted the other way around or completely ignored 🤔

image

Also, when I want to manually set the rule, starting with copy/paste directly from config, ESLint complains with this:

"@graphql-eslint/alphabetize": [
	"error",
	{
		definitions: true,
		fields: [
			"ObjectTypeDefinition",
			"InterfaceTypeDefinition",
			"InputObjectTypeDefinition",
		],
		values: true,
		arguments: [
			"FieldDefinition",
			"Field",
			"DirectiveDefinition",
			"Directive",
		],
		groups: ["id", "*", "createdAt", "updatedAt"],
	},
],
[Error - 11:24:00 PM] .eslintrc.js#overrides[0]: 	Configuration for rule "@graphql-eslint/alphabetize" is invalid: 	Value true should be array. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new option prefix for match-document-filename rule
3 participants