Fixed compiler issues, fixed several algorithms, 64-bit machine fix, add Makefile to build and run all tests, rollup of all previous (to #15) pull requests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typedefs used in header files are protected by the CRYPTO_TYPES macro so that if one includes more thann one header files, one does not see multiple typedef errors. Changed BYTE and WORD typedefs to ensure that they are unsigned 8 and 32 bit values.
Fixed how 3DES triggers encrypt and decrypt. Fixed header guard symbol.
lcn2
changed the title
lcn2
changed the title
lcn2
changed the title
Each test will exit 0 if all is well, or exit 1 if there was an error. Now 'make test' will report of any of the tests failed or of all tests passed. It will exit non-zero of any of the tests failed.
On some systems, the base64_test() call would fail because an output buffer was not zeroized befure using it.
lcn2
changed the title
Open
|
I also think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I fixed a number of compiler warnings and add a Makefile to make (pun intended) it easy to compile and run all of the tests. If any test fails, that test will exit with an error. The 'make test' will report of all tests passed or if any test failed.
A .gitignore has been added to ignore all of the executables.
Fixed problems where AES caused some compilers to become confused while doing 3DES.
A bug in RC4, where some variables were incorrectly initialized, was fixed.
On some systems the base64 test would fail because an output buffer was not properly zeroized before use.
Changes were made to header files so that multiple header files may be included by another program. I fixed types for WORD so that 64-bit machines would use the correct size. In doing so I adjusted the BYTE type to use the same <stdint.h> convention.
I added a handy function that allows one to perform a sha256() hash in one call.
Fixed rot13 to work correctly when given non-ASCII data.
Make a fix to RC4 (ARCFOUR). While the test worked, the mechanism did not work in that state was not being preserved across calls as the comment indicated. This limitation has been fixed and replaces previous RC4 fixes relating to the I and j variables.
Best wishes and thanks
p.s. I noticed a number of other pending pull requests made a few (but not all) of the above fixes. To help I broke up this pull request into multiple commits to help identify any overlap. I did not, however, include pull request #11 as it changed the output of the test and failed to properly format it.