Skip to content

[AutoPR Microsoft.Azure.Management.EventGrid] EventGrid: Support for IPFiltering feature in update Domains & Topics scenarios #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openapi-sdkautomation wants to merge 1 commit into from
Closed

[AutoPR Microsoft.Azure.Management.EventGrid] EventGrid: Support for IPFiltering feature in update Domains & Topics scenarios #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/DomainsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,19 +315,19 @@ internal DomainsOperations(EventGridManagementClient client)
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public async Task<AzureOperationResponse<Domain>> UpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken))
public async Task<AzureOperationResponse<Domain>> UpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken))
{
// Send Request
AzureOperationResponse<Domain> _response = await BeginUpdateWithHttpMessagesAsync(resourceGroupName, domainName, tags, customHeaders, cancellationToken).ConfigureAwait(false);
AzureOperationResponse<Domain> _response = await BeginUpdateWithHttpMessagesAsync(resourceGroupName, domainName, domainUpdateParameters, customHeaders, cancellationToken).ConfigureAwait(false);
return await Client.GetPutOrPatchOperationResultAsync(_response, customHeaders, cancellationToken).ConfigureAwait(false);
}

Expand Down Expand Up @@ -1575,8 +1575,8 @@ internal DomainsOperations(EventGridManagementClient client)
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
Expand All @@ -1599,7 +1599,7 @@ internal DomainsOperations(EventGridManagementClient client)
/// <return>
/// A response object containing the response body and response headers.
/// </return>
public async Task<AzureOperationResponse<Domain>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken))
public async Task<AzureOperationResponse<Domain>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken))
{
if (Client.SubscriptionId == null)
{
Expand All @@ -1613,14 +1613,13 @@ internal DomainsOperations(EventGridManagementClient client)
{
throw new ValidationException(ValidationRules.CannotBeNull, "domainName");
}
if (Client.ApiVersion == null)
if (domainUpdateParameters == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.ApiVersion");
throw new ValidationException(ValidationRules.CannotBeNull, "domainUpdateParameters");
}
DomainUpdateParameters domainUpdateParameters = new DomainUpdateParameters();
if (tags != null)
if (Client.ApiVersion == null)
{
domainUpdateParameters.Tags = tags;
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.ApiVersion");
}
// Tracing
bool _shouldTrace = ServiceClientTracing.IsEnabled;
Expand Down
34 changes: 16 additions & 18 deletions ...entgrid/Microsoft.Azure.Management.EventGrid/src/Generated/DomainsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ namespace Microsoft.Azure.Management.EventGrid
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Models;
using System.Collections;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;

Expand Down Expand Up @@ -181,12 +179,12 @@ public static void Delete(this IDomainsOperations operations, string resourceGro
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
public static Domain Update(this IDomainsOperations operations, string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>))
public static Domain Update(this IDomainsOperations operations, string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters)
{
return operations.UpdateAsync(resourceGroupName, domainName, tags).GetAwaiter().GetResult();
return operations.UpdateAsync(resourceGroupName, domainName, domainUpdateParameters).GetAwaiter().GetResult();
}

/// <summary>
Expand All @@ -204,15 +202,15 @@ public static void Delete(this IDomainsOperations operations, string resourceGro
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async Task<Domain> UpdateAsync(this IDomainsOperations operations, string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), CancellationToken cancellationToken = default(CancellationToken))
public static async Task<Domain> UpdateAsync(this IDomainsOperations operations, string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, CancellationToken cancellationToken = default(CancellationToken))
{
using (var _result = await operations.UpdateWithHttpMessagesAsync(resourceGroupName, domainName, tags, null, cancellationToken).ConfigureAwait(false))
using (var _result = await operations.UpdateWithHttpMessagesAsync(resourceGroupName, domainName, domainUpdateParameters, null, cancellationToken).ConfigureAwait(false))
{
return _result.Body;
}
Expand Down Expand Up @@ -558,12 +556,12 @@ public static void BeginDelete(this IDomainsOperations operations, string resour
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
public static Domain BeginUpdate(this IDomainsOperations operations, string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>))
public static Domain BeginUpdate(this IDomainsOperations operations, string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters)
{
return operations.BeginUpdateAsync(resourceGroupName, domainName, tags).GetAwaiter().GetResult();
return operations.BeginUpdateAsync(resourceGroupName, domainName, domainUpdateParameters).GetAwaiter().GetResult();
}

/// <summary>
Expand All @@ -581,15 +579,15 @@ public static void BeginDelete(this IDomainsOperations operations, string resour
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async Task<Domain> BeginUpdateAsync(this IDomainsOperations operations, string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), CancellationToken cancellationToken = default(CancellationToken))
public static async Task<Domain> BeginUpdateAsync(this IDomainsOperations operations, string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, CancellationToken cancellationToken = default(CancellationToken))
{
using (var _result = await operations.BeginUpdateWithHttpMessagesAsync(resourceGroupName, domainName, tags, null, cancellationToken).ConfigureAwait(false))
using (var _result = await operations.BeginUpdateWithHttpMessagesAsync(resourceGroupName, domainName, domainUpdateParameters, null, cancellationToken).ConfigureAwait(false))
{
return _result.Body;
}
Expand Down
12 changes: 6 additions & 6 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/IDomainsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ public partial interface IDomainsOperations
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
Expand All @@ -138,7 +138,7 @@ public partial interface IDomainsOperations
/// <exception cref="Microsoft.Rest.ValidationException">
/// Thrown when a required parameter is null
/// </exception>
Task<AzureOperationResponse<Domain>> UpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<AzureOperationResponse<Domain>> UpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
/// <summary>
/// List domains under an Azure subscription.
/// </summary>
Expand Down Expand Up @@ -346,8 +346,8 @@ public partial interface IDomainsOperations
/// <param name='domainName'>
/// Name of the domain.
/// </param>
/// <param name='tags'>
/// Tags of the domains resource
/// <param name='domainUpdateParameters'>
/// Domain update information.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
Expand All @@ -364,7 +364,7 @@ public partial interface IDomainsOperations
/// <exception cref="Microsoft.Rest.ValidationException">
/// Thrown when a required parameter is null
/// </exception>
Task<AzureOperationResponse<Domain>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<AzureOperationResponse<Domain>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string domainName, DomainUpdateParameters domainUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
/// <summary>
/// List domains under an Azure subscription.
/// </summary>
Expand Down
6 changes: 3 additions & 3 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/ITopicTypesOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ public partial interface ITopicTypesOperations
/// </exception>
Task<AzureOperationResponse<TopicTypeInfo>> GetWithHttpMessagesAsync(string topicTypeName, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
/// <summary>
/// List event types
/// List event types.
/// </summary>
/// <remarks>
/// List event types for a topic type
/// List event types for a topic type.
/// </remarks>
/// <param name='topicTypeName'>
/// Name of the topic type
/// Name of the topic type.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
Expand Down
12 changes: 6 additions & 6 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/ITopicsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ public partial interface ITopicsOperations
/// <param name='topicName'>
/// Name of the topic.
/// </param>
/// <param name='tags'>
/// Tags of the resource.
/// <param name='topicUpdateParameters'>
/// Topic update information.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
Expand All @@ -137,7 +137,7 @@ public partial interface ITopicsOperations
/// <exception cref="Microsoft.Rest.ValidationException">
/// Thrown when a required parameter is null
/// </exception>
Task<AzureOperationResponse<Topic>> UpdateWithHttpMessagesAsync(string resourceGroupName, string topicName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<AzureOperationResponse<Topic>> UpdateWithHttpMessagesAsync(string resourceGroupName, string topicName, TopicUpdateParameters topicUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
/// <summary>
/// List topics under an Azure subscription.
/// </summary>
Expand Down Expand Up @@ -378,8 +378,8 @@ public partial interface ITopicsOperations
/// <param name='topicName'>
/// Name of the topic.
/// </param>
/// <param name='tags'>
/// Tags of the resource.
/// <param name='topicUpdateParameters'>
/// Topic update information.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
Expand All @@ -396,7 +396,7 @@ public partial interface ITopicsOperations
/// <exception cref="Microsoft.Rest.ValidationException">
/// Thrown when a required parameter is null
/// </exception>
Task<AzureOperationResponse<Topic>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string topicName, IDictionary<string, string> tags = default(IDictionary<string, string>), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<AzureOperationResponse<Topic>> BeginUpdateWithHttpMessagesAsync(string resourceGroupName, string topicName, TopicUpdateParameters topicUpdateParameters, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
/// <summary>
/// List topics under an Azure subscription.
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/Models/Domain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ public Domain()
public InputSchemaMapping InputSchemaMapping { get; set; }

/// <summary>
/// Gets or sets metric resource id for the domain.
/// Gets metric resource id for the domain.
/// </summary>
[JsonProperty(PropertyName = "properties.metricResourceId")]
public string MetricResourceId { get; set; }
public string MetricResourceId { get; private set; }

/// <summary>
/// Gets or sets this determines if IP filtering rules ought to be
Expand Down
25 changes: 24 additions & 1 deletion ...tgrid/Microsoft.Azure.Management.EventGrid/src/Generated/Models/DomainUpdateParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,17 @@ public DomainUpdateParameters()
/// Initializes a new instance of the DomainUpdateParameters class.
/// </summary>
/// <param name="tags">Tags of the domains resource</param>
public DomainUpdateParameters(IDictionary<string, string> tags = default(IDictionary<string, string>))
/// <param name="allowTrafficFromAllIPs">This determines if IP
/// filtering rules ought to be evaluated or not. By default it will
/// not evaluate and will allow traffic from all IPs.</param>
/// <param name="inboundIpRules">This determines the IP filtering rules
/// that ought be applied when events are received on this
/// domain.</param>
public DomainUpdateParameters(IDictionary<string, string> tags = default(IDictionary<string, string>), bool? allowTrafficFromAllIPs = default(bool?), IList<InboundIpRule> inboundIpRules = default(IList<InboundIpRule>))
{
Tags = tags;
AllowTrafficFromAllIPs = allowTrafficFromAllIPs;
InboundIpRules = inboundIpRules;
CustomInit();
}

Expand All @@ -49,5 +57,20 @@ public DomainUpdateParameters()
[JsonProperty(PropertyName = "tags")]
public IDictionary<string, string> Tags { get; set; }

/// <summary>
/// Gets or sets this determines if IP filtering rules ought to be
/// evaluated or not. By default it will not evaluate and will allow
/// traffic from all IPs.
/// </summary>
[JsonProperty(PropertyName = "allowTrafficFromAllIPs")]
public bool? AllowTrafficFromAllIPs { get; set; }

/// <summary>
/// Gets or sets this determines the IP filtering rules that ought be
/// applied when events are received on this domain.
/// </summary>
[JsonProperty(PropertyName = "inboundIpRules")]
public IList<InboundIpRule> InboundIpRules { get; set; }

}
}
4 changes: 2 additions & 2 deletions sdk/eventgrid/Microsoft.Azure.Management.EventGrid/src/Generated/Models/Topic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ public Topic()
public InputSchemaMapping InputSchemaMapping { get; set; }

/// <summary>
/// Gets or sets metric resource id for the topic.
/// Gets metric resource id for the topic.
/// </summary>
[JsonProperty(PropertyName = "properties.metricResourceId")]
public string MetricResourceId { get; set; }
public string MetricResourceId { get; private set; }

/// <summary>
/// Gets or sets this determines if IP filtering rules ought to be
Expand Down
Loading