[AutoPR @azure/arm-datafactory] [DataFactory] Fix Expression mode for SqlServerStoredProcedureActivity

sdk/datafactory/arm-datafactory/CHANGELOG.md

@@ -1,15 +1,21 @@
 # Release History
+
+## 10.3.0 (2022-03-28)
+
+**Features**
 
-## 10.2.1 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
-
+  - Added Type Alias CredentialReferenceType
+  - Added Type Alias DataFlowReferenceType
+  - Added Type Alias ManagedVirtualNetworkReferenceType
+  - Added Type Alias TriggerReferenceType
+  - Type Alias SqlServerStoredProcedureActivity has a new parameter storedProcedureParameters
+  - Type Alias WebActivity has a new parameter disableCertValidation
+  - Added Enum KnownCredentialReferenceType
+  - Added Enum KnownDataFlowReferenceType
+  - Added Enum KnownManagedVirtualNetworkReferenceType
+  - Added Enum KnownTriggerReferenceType
+
+
 ## 10.2.0 (2022-02-22)
 
 **Features**

sdk/datafactory/arm-datafactory/README.md

@@ -16,8 +16,6 @@ The Azure Data Factory V2 management API provides a RESTful set of web services
 - [LTS versions of Node.js](https://nodejs.org/about/releases/)
 - Latest versions of Safari, Chrome, Edge and Firefox.
 
-See our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.
-
 ### Prerequisites
 
 - An [Azure subscription][azure_sub].
@@ -51,17 +49,8 @@ For more information about how to create an Azure AD Application check out [this
 ```javascript
 const { DataFactoryManagementClient } = require("@azure/arm-datafactory");
 const { DefaultAzureCredential } = require("@azure/identity");
-// For client-side applications running in the browser, use InteractiveBrowserCredential instead of DefaultAzureCredential. See https://aka.ms/azsdk/js/identity/examples for more details.
-
 const subscriptionId = "00000000-0000-0000-0000-000000000000";
 const client = new DataFactoryManagementClient(new DefaultAzureCredential(), subscriptionId);
-
-// For client-side applications running in the browser, use this code instead:
-// const credential = new InteractiveBrowserCredential({
-//   tenantId: "<YOUR_TENANT_ID>",
-//   clientId: "<YOUR_CLIENT_ID>"
-// });
-// const client = new DataFactoryManagementClient(credential, subscriptionId);
 ```
 
 

sdk/datafactory/arm-datafactory/_meta.json

@@ -1,7 +1,8 @@
 {
-  "commit": "bb9f1204f9a337404ff7e7b73b4c7b4ddde7f8f1",
+  "commit": "166e067ab84ef7c19e73f29c9ce8101c2bd0a3bb",
   "readme": "specification/datafactory/resource-manager/readme.md",
-  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md --use=@autorest/[email protected].20220218.1",
+  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md --use=@autorest/[email protected].20220105.1",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "use": "@autorest/[email protected]"
+  "release_tool": "@azure-tools/[email protected]",
+  "use": "@autorest/[email protected]"
 }

sdk/datafactory/arm-datafactory/package.json

@@ -3,7 +3,7 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for DataFactoryManagementClient.",
-  "version": "10.2.1",
+  "version": "10.3.0",
   "engines": {
     "node": ">=12.0.0"
   },
@@ -29,13 +29,13 @@
   "types": "./types/arm-datafactory.d.ts",
   "devDependencies": {
     "@microsoft/api-extractor": "^7.18.11",
-    "@rollup/plugin-commonjs": "^21.0.1",
-    "@rollup/plugin-json": "^4.1.0",
-    "@rollup/plugin-multi-entry": "^4.1.0",
-    "@rollup/plugin-node-resolve": "^13.1.3",
+    "@rollup/plugin-commonjs": "11.0.2",
+    "@rollup/plugin-json": "^4.0.0",
+    "@rollup/plugin-multi-entry": "^3.0.0",
+    "@rollup/plugin-node-resolve": "^8.0.0",
     "mkdirp": "^1.0.4",
-    "rollup": "^2.66.1",
-    "rollup-plugin-sourcemaps": "^0.6.3",
+    "rollup": "^1.16.3",
+    "rollup-plugin-sourcemaps": "^0.4.2",
     "typescript": "~4.2.0",
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
@@ -98,13 +98,5 @@
     "docs": "echo skipped"
   },
   "sideEffects": false,
-  "//metadata": {
-    "constantPaths": [
-      {
-        "path": "src/dataFactoryManagementClient.ts",
-        "prefix": "packageDetails"
-      }
-    ]
-  },
   "autoPublish": true
-}
+}

sdk/datafactory/arm-datafactory/review/arm-datafactory.api.md

@@ -1480,9 +1480,12 @@ export { Credential_2 as Credential }
 export interface CredentialReference {
     [property: string]: any;
     referenceName: string;
-    type: "CredentialReference";
+    type: CredentialReferenceType;
 }
 
+// @public
+export type CredentialReferenceType = string;
+
 // @public
 export type CredentialResource = SubResource & {
     properties: CredentialUnion;
@@ -1788,9 +1791,12 @@ export interface DataFlowReference {
         [propertyName: string]: Record<string, unknown>;
     };
     referenceName: string;
-    type: "DataFlowReference";
+    type: DataFlowReferenceType;
 }
 
+// @public
+export type DataFlowReferenceType = string;
+
 // @public
 export type DataFlowResource = SubResource & {
     properties: DataFlowUnion;
@@ -4047,6 +4053,12 @@ export enum KnownCosmosDbServicePrincipalCredentialType {
     ServicePrincipalKey = "ServicePrincipalKey"
 }
 
+// @public
+export enum KnownCredentialReferenceType {
+    // (undocumented)
+    CredentialReference = "CredentialReference"
+}
+
 // @public
 export enum KnownDataFlowComputeType {
     // (undocumented)
@@ -4067,6 +4079,12 @@ export enum KnownDataFlowDebugCommandType {
     ExecuteStatisticsQuery = "executeStatisticsQuery"
 }
 
+// @public
+export enum KnownDataFlowReferenceType {
+    // (undocumented)
+    DataFlowReference = "DataFlowReference"
+}
+
 // @public
 export enum KnownDatasetCompressionLevel {
     // (undocumented)
@@ -4397,6 +4415,12 @@ export enum KnownManagedIntegrationRuntimeNodeStatus {
     Unavailable = "Unavailable"
 }
 
+// @public
+export enum KnownManagedVirtualNetworkReferenceType {
+    // (undocumented)
+    ManagedVirtualNetworkReference = "ManagedVirtualNetworkReference"
+}
+
 // @public
 export enum KnownMongoDbAuthenticationType {
     // (undocumented)
@@ -4919,6 +4943,12 @@ export enum KnownTeradataPartitionOption {
     None = "None"
 }
 
+// @public
+export enum KnownTriggerReferenceType {
+    // (undocumented)
+    TriggerReference = "TriggerReference"
+}
+
 // @public
 export enum KnownTriggerRunStatus {
     // (undocumented)
@@ -5301,9 +5331,12 @@ export interface ManagedVirtualNetworkListResponse {
 // @public
 export interface ManagedVirtualNetworkReference {
     referenceName: string;
-    type: "ManagedVirtualNetworkReference";
+    type: ManagedVirtualNetworkReferenceType;
 }
 
+// @public
+export type ManagedVirtualNetworkReferenceType = string;
+
 // @public
 export type ManagedVirtualNetworkResource = SubResource & {
     properties: ManagedVirtualNetwork;
@@ -7417,9 +7450,7 @@ export type SqlServerSource = TabularSource & {
 export type SqlServerStoredProcedureActivity = ExecutionActivity & {
     type: "SqlServerStoredProcedure";
     storedProcedureName: Record<string, unknown>;
-    storedProcedureParameters?: {
-        [propertyName: string]: StoredProcedureParameter;
-    };
+    storedProcedureParameters?: Record<string, unknown>;
 };
 
 // @public
@@ -7900,9 +7931,12 @@ export interface TriggerQueryResponse {
 // @public
 export interface TriggerReference {
     referenceName: string;
-    type: "TriggerReference";
+    type: TriggerReferenceType;
 }
 
+// @public
+export type TriggerReferenceType = string;
+
 // @public
 export type TriggerResource = SubResource & {
     properties: TriggerUnion;
@@ -8193,6 +8227,7 @@ export type WebActivity = ExecutionActivity & {
     headers?: Record<string, unknown>;
     body?: Record<string, unknown>;
     authentication?: WebActivityAuthentication;
+    disableCertValidation?: boolean;
     datasets?: DatasetReference[];
     linkedServices?: LinkedServiceReference[];
     connectVia?: IntegrationRuntimeReference;

sdk/datafactory/arm-datafactory/rollup.config.js

@@ -14,14 +14,62 @@ import json from "@rollup/plugin-json";
 
 import nodeBuiltins from "builtin-modules";
 
+/**
+ * Gets the proper configuration needed for rollup's commonJS plugin for @opentelemetry/api.
+ *
+ * NOTE: this manual configuration is only needed because OpenTelemetry uses an
+ * __exportStar downleveled helper function to declare its exports which confuses
+ * rollup's automatic discovery mechanism.
+ *
+ * @returns an object reference that can be `...`'d into your cjs() configuration.
+ */
+export function openTelemetryCommonJs() {
+  const namedExports = {};
+
+  for (const key of [
+    "@opentelemetry/api",
+    "@azure/core-tracing/node_modules/@opentelemetry/api"
+  ]) {
+    namedExports[key] = [
+      "SpanKind",
+      "TraceFlags",
+      "getSpan",
+      "setSpan",
+      "SpanStatusCode",
+      "getSpanContext",
+      "setSpanContext"
+    ];
+  }
+
+  const releasedOpenTelemetryVersions = ["0.10.2", "1.0.0-rc.0"];
+
+  for (const version of releasedOpenTelemetryVersions) {
+    namedExports[
+      // working around a limitation in the rollup common.js plugin - it's not able to resolve these modules so the named exports listed above will not get applied. We have to drill down to the actual path.
+      `../../../common/temp/node_modules/.pnpm/@opentelemetry/api@${version}/node_modules/@opentelemetry/api/build/src/index.js`
+    ] = [
+      "SpanKind",
+      "TraceFlags",
+      "getSpan",
+      "setSpan",
+      "StatusCode",
+      "CanonicalCode",
+      "getSpanContext",
+      "setSpanContext"
+    ];
+  }
+
+  return namedExports;
+}
+
 // #region Warning Handler
 
 /**
- * A function that can determine whether a rollup warning should be ignored. If
+ * A function that can determine whether a rollupwarning should be ignored. If
  * the function returns `true`, then the warning will not be displayed.
  */
 
-function ignoreNiseSinonEval(warning) {
+function ignoreNiseSinonEvalWarnings(warning) {
   return (
     warning.code === "EVAL" &&
     warning.id &&
@@ -30,14 +78,17 @@ function ignoreNiseSinonEval(warning) {
   );
 }
 
-function ignoreChaiCircularDependency(warning) {
+function ignoreChaiCircularDependencyWarnings(warning) {
   return (
     warning.code === "CIRCULAR_DEPENDENCY" &&
     warning.importer && warning.importer.includes("node_modules/chai") === true
   );
 }
 
-const warningInhibitors = [ignoreChaiCircularDependency, ignoreNiseSinonEval];
+const warningInhibitors = [
+  ignoreChaiCircularDependencyWarnings,
+  ignoreNiseSinonEvalWarnings
+];
 
 /**
  * Construct a warning handler for the shared rollup configuration
@@ -71,7 +122,22 @@ function makeBrowserTestConfig() {
       nodeResolve({
         mainFields: ["module", "browser"]
       }),
-      cjs(),
+      cjs({
+        namedExports: {
+          // Chai's strange internal architecture makes it impossible to statically
+          // analyze its exports.
+          chai: [
+            "version",
+            "use",
+            "util",
+            "config",
+            "expect",
+            "should",
+            "assert"
+          ],
+          ...openTelemetryCommonJs()
+        }
+      }),
       json(),
       sourcemaps()
       //viz({ filename: "dist-test/browser-stats.html", sourcemap: true })
@@ -107,7 +173,7 @@ export function makeConfig(pkg, options) {
     ],
     output: { file: "dist/index.js", format: "cjs", sourcemap: true },
     preserveSymlinks: false,
-    plugins: [sourcemaps(), nodeResolve()]
+    plugins: [sourcemaps(), nodeResolve(), cjs()]
   };
 
   const config = [baseConfig];