Skip to content

[AutoPR @azure/arm-compute] Support for Deep Deletion of disks #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
openapi-sdkautomation wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[AutoPR @azure/arm-compute] Support for Deep Deletion of disks #4155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/compute/arm-compute/src/computeManagementClientContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class ComputeManagementClientContext extends msRestAzure.AzureServiceClie
if (!options) {
options = {};
}
if (!options.userAgent) {
if(!options.userAgent) {
const defaultUserAgent = msRestAzure.getDefaultUserAgentValue();
options.userAgent = `${packageName}/${packageVersion} ${defaultUserAgent}`;
}
Expand All @@ -50,10 +50,10 @@ export class ComputeManagementClientContext extends msRestAzure.AzureServiceClie
this.credentials = credentials;
this.subscriptionId = subscriptionId;

if (options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
if(options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
this.acceptLanguage = options.acceptLanguage;
}
if (options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
if(options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
this.longRunningOperationRetryTimeout = options.longRunningOperationRetryTimeout;
}
}
Expand Down
25 changes: 25 additions & 0 deletions sdk/compute/arm-compute/src/models/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1758,6 +1758,15 @@ export interface OSDisk {
* The managed disk parameters.
*/
managedDisk?: ManagedDiskParameters;
/**
* Specifies whether OS Disk should be deleted or detached upon VM deletion. <br><br> Possible
* values: <br><br> **Delete** If this value is used, the OS disk is deleted when VM is
* deleted.<br><br> **Detach** If this value is used, the os disk is retained after VM is
* deleted. <br><br> The default value is set to **detach**. For an ephemeral OS Disk, the
* default value is set to **Delete**. User cannot change the delete option for ephemeral OS
* Disk. Possible values include: 'Delete', 'Detach'
*/
deleteOption?: DiskDeleteOptionTypes;
}

/**
Expand Down Expand Up @@ -1843,6 +1852,14 @@ export interface DataDisk {
* 'true' along with setting detachOption: 'ForceDetach'. Possible values include: 'ForceDetach'
*/
detachOption?: DiskDetachOptionTypes;
/**
* Specifies whether data disk should be deleted or detached upon VM deletion.<br><br> Possible
* values: <br><br> **Delete** If this value is used, the data disk is deleted when VM is
* deleted.<br><br> **Detach** If this value is used, the data disk is retained after VM is
* deleted.<br><br> The default value is set to **detach**. Possible values include: 'Delete',
* 'Detach'
*/
deleteOption?: DiskDeleteOptionTypes;
}

/**
Expand Down Expand Up @@ -9357,6 +9374,14 @@ export type DiskCreateOptionTypes = 'FromImage' | 'Empty' | 'Attach';
*/
export type DiskDetachOptionTypes = 'ForceDetach';

/**
* Defines values for DiskDeleteOptionTypes.
* Possible values include: 'Delete', 'Detach'
* @readonly
* @enum {string}
*/
export type DiskDeleteOptionTypes = 'Delete' | 'Detach';

/**
* Defines values for StorageAccountTypes.
* Possible values include: 'Standard_LRS', 'Premium_LRS', 'StandardSSD_LRS', 'UltraSSD_LRS',
Expand Down
12 changes: 12 additions & 0 deletions sdk/compute/arm-compute/src/models/mappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2731,6 +2731,12 @@ export const OSDisk: msRest.CompositeMapper = {
name: "Composite",
className: "ManagedDiskParameters"
}
},
deleteOption: {
serializedName: "deleteOption",
type: {
name: "String"
}
}
}
}
Expand Down Expand Up @@ -2831,6 +2837,12 @@ export const DataDisk: msRest.CompositeMapper = {
type: {
name: "String"
}
},
deleteOption: {
serializedName: "deleteOption",
type: {
name: "String"
}
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions sdk/compute/arm-compute/src/models/parameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const apiVersion0: msRest.OperationQueryParameter = {
required: true,
isConstant: true,
serializedName: "api-version",
defaultValue: '2020-12-01',
defaultValue: '2021-03-01',
type: {
name: "String"
}
Expand All @@ -49,7 +49,7 @@ export const apiVersion2: msRest.OperationQueryParameter = {
required: true,
isConstant: true,
serializedName: "api-version",
defaultValue: '2019-12-01',
defaultValue: '2020-12-01',
type: {
name: "String"
}
Expand All @@ -61,7 +61,7 @@ export const apiVersion3: msRest.OperationQueryParameter = {
required: true,
isConstant: true,
serializedName: "api-version",
defaultValue: '2021-03-01',
defaultValue: '2019-12-01',
type: {
name: "String"
}
Expand Down
12 changes: 6 additions & 6 deletions sdk/compute/arm-compute/src/operations/cloudServiceOperatingSystems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ const getOSVersionOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -247,7 +247,7 @@ const listOSVersionsOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -272,7 +272,7 @@ const getOSFamilyOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -296,7 +296,7 @@ const listOSFamiliesOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -320,7 +320,7 @@ const listOSVersionsNextOperationSpec: msRest.OperationSpec = {
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -344,7 +344,7 @@ const listOSFamiliesNextOperationSpec: msRest.OperationSpec = {
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand Down
18 changes: 9 additions & 9 deletions sdk/compute/arm-compute/src/operations/cloudServiceRoleInstances.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ const getOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3,
Parameters.apiVersion0,
Parameters.expand1
],
headerParameters: [
Expand All @@ -378,7 +378,7 @@ const getInstanceViewOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -403,7 +403,7 @@ const listOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3,
Parameters.apiVersion0,
Parameters.expand1
],
headerParameters: [
Expand All @@ -430,7 +430,7 @@ const getRemoteDesktopFileOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand Down Expand Up @@ -461,7 +461,7 @@ const beginDeleteMethodOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -487,7 +487,7 @@ const beginRestartOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -512,7 +512,7 @@ const beginReimageOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -537,7 +537,7 @@ const beginRebuildOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -560,7 +560,7 @@ const listNextOperationSpec: msRest.OperationSpec = {
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion3,
Parameters.apiVersion0,
Parameters.expand1
],
headerParameters: [
Expand Down
6 changes: 3 additions & 3 deletions sdk/compute/arm-compute/src/operations/cloudServiceRoles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ const getOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -161,7 +161,7 @@ const listOperationSpec: msRest.OperationSpec = {
Parameters.subscriptionId
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand All @@ -185,7 +185,7 @@ const listNextOperationSpec: msRest.OperationSpec = {
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion3
Parameters.apiVersion0
],
headerParameters: [
Parameters.acceptLanguage
Expand Down
Loading