[AutoPR @azure/arm-links] update

eng/common/scripts/Verify-Links.ps1

@@ -30,6 +30,7 @@ function NormalizeUrl([string]$url){
     $url = "file://" + (Resolve-Path $url).ToString();
   }
 
+  Write-Verbose "The url to check against: $url."
   $uri = [System.Uri]$url;
 
   if ($script:baseUrl -eq "") {

eng/common/scripts/get-markdown-files-from-changed-files.ps1

@@ -0,0 +1,49 @@
+param (
+  # The root repo we scaned with.
+  [string] $RootRepo = '$PSScriptRoot/../../..',
+  # The target branch to compare with.
+  [string] $targetBranch = "origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH}"
+)
+$deletedFiles = (git diff $targetBranch HEAD --name-only --diff-filter=D)
+$renamedFiles = (git diff $targetBranch HEAD --diff-filter=R)
+$changedMarkdowns = (git diff $targetBranch HEAD --name-only -- '*.md')
+
+$beforeRenameFiles = @()
+# Retrieve the 'renamed from' files. Git command only returns back the files after rename. 
+# In order to have the files path before rename, it has to do some regex checking. 
+# It is better to be replaced by more reliable commands if any.
+foreach ($file in $renamedFiles) {
+  if ($file -match "^rename from (.*)$") {
+    $beforeRenameFiles += $file -replace "^rename from (.*)$", '$1'
+  }
+}
+# A combined list of deleted and renamed files.
+$relativePathLinks = ($deletedFiles + $beforeRenameFiles)
+# Removed the deleted markdowns. 
+$changedMarkdowns = $changedMarkdowns | Where-Object { $deletedFiles -notcontains $_ }
+# Scan all markdowns and find if it contains the deleted or renamed files.
+$markdownContainLinks = @()
+$allMarkdownFiles = Get-ChildItem -Path $RootRepo -Recurse -Include *.md
+foreach ($f in $allMarkdownFiles) {
+  $filePath = $f.FullName
+  $content = Get-Content -Path $filePath -Raw
+  foreach ($l in $relativePathLinks) {
+    if ($content -match $l) {
+      $markdownContainLinks += $filePath
+      break
+    }
+  }
+}
+
+# Convert markdowns path of the PR to absolute path.
+$adjustedReadmes = $changedMarkdowns | Foreach-Object { Resolve-Path $_ }
+$markdownContainLinks += $adjustedReadmes
+
+# Get rid of any duplicated ones.
+$allMarkdowns = [string[]]($markdownContainLinks | Sort-Object | Get-Unique)
+
+Write-Host "Here are all markdown files we need to check based on the changed files:"
+foreach ($file in $allMarkdowns) {
+  Write-Host "    $file"
+}
+return $allMarkdowns

sdk/identity/identity/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Release History
 
+## 1.2.1 (Unreleased)
+
+
 ## 1.2.0 (2020-11-11)
 
 ### Changes since 1.1.\*

sdk/identity/identity/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@azure/identity",
   "sdk-type": "client",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Provides credential implementations for Azure SDK libraries that can authenticate with Azure Active Directory",
   "main": "dist/index.js",
   "module": "dist-esm/src/index.js",

sdk/links/arm-links/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019 Microsoft
+Copyright (c) 2020 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/links/arm-links/README.md

@@ -15,21 +15,21 @@ npm install @azure/arm-links
 
 ### How to use
 
-#### nodejs - Authentication, client creation and list operations as an example written in TypeScript.
+#### nodejs - client creation and list operations as an example written in TypeScript.
 
 ##### Install @azure/ms-rest-nodeauth
 
+- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
 ```bash
-npm install @azure/ms-rest-nodeauth
+npm install @azure/ms-rest-nodeauth@"^3.0.0"
 ```
 
 ##### Sample code
 
+While the below sample uses the interactive login, other authentication options can be found in the [README.md file of @azure/ms-rest-nodeauth](https://www.npmjs.com/package/@azure/ms-rest-nodeauth) package
 ```typescript
-import * as msRest from "@azure/ms-rest-js";
-import * as msRestAzure from "@azure/ms-rest-azure-js";
-import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
-import { ManagementLinkClient, ManagementLinkModels, ManagementLinkMappers } from "@azure/arm-links";
+const msRestNodeAuth = require("@azure/ms-rest-nodeauth");
+const { ManagementLinkClient } = require("@azure/arm-links");
 const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
 
 msRestNodeAuth.interactiveLogin().then((creds) => {
@@ -95,4 +95,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
 
 - [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)
 
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Flinks%2Farm-links%2FREADME.png)
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/links/arm-links/README.png)

sdk/links/arm-links/package.json

@@ -4,9 +4,9 @@
   "description": "ManagementLinkClient Library with typescript type definitions for node.js and browser.",
   "version": "1.0.2",
   "dependencies": {
-    "@azure/ms-rest-azure-js": "^1.3.2",
-    "@azure/ms-rest-js": "^1.8.1",
-    "tslib": "^1.9.3"
+    "@azure/ms-rest-azure-js": "^2.0.1",
+    "@azure/ms-rest-js": "^2.0.4",
+    "tslib": "^1.10.0"
   },
   "keywords": [
     "node",
@@ -20,11 +20,11 @@
   "module": "./esm/managementLinkClient.js",
   "types": "./esm/managementLinkClient.d.ts",
   "devDependencies": {
-    "typescript": "^3.1.1",
-    "rollup": "^0.66.2",
-    "rollup-plugin-node-resolve": "^3.4.0",
+    "typescript": "^3.5.3",
+    "rollup": "^1.18.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
-    "uglify-js": "^3.4.9"
+    "uglify-js": "^3.6.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/links/arm-links",
   "repository": {

sdk/links/arm-links/rollup.config.js

@@ -21,15 +21,15 @@ const config = {
       "@azure/ms-rest-azure-js": "msRestAzure"
     },
     banner: `/*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */`
   },
   plugins: [
-    nodeResolve({ module: true }),
+    nodeResolve({ mainFields: ['module', 'main'] }),
     sourcemaps()
   ]
 };

sdk/links/arm-links/src/managementLinkClient.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is

sdk/links/arm-links/src/managementLinkClientContext.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is

sdk/links/arm-links/src/models/index.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
@@ -123,6 +123,28 @@ export interface ResourceLinksListAtSourceScopeOptionalParams extends msRest.Req
   filter?: string;
 }
 
+/**
+ * Optional Parameters.
+ */
+export interface ResourceLinksListAtSubscriptionNextOptionalParams extends msRest.RequestOptionsBase {
+  /**
+   * The filter to apply on the list resource links operation. The supported filter for list
+   * resource links is targetId. For example, $filter=targetId eq {value}
+   */
+  filter?: string;
+}
+
+/**
+ * Optional Parameters.
+ */
+export interface ResourceLinksListAtSourceScopeNextOptionalParams extends msRest.RequestOptionsBase {
+  /**
+   * The filter to apply when getting resource links. To get links only at the specified scope (not
+   * below the scope), use Filter.atScope().
+   */
+  filter?: string;
+}
+
 /**
  * An interface representing ManagementLinkClientOptions.
  */

sdk/links/arm-links/src/models/mappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/links/arm-links/src/models/operationsMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/links/arm-links/src/models/parameters.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is

sdk/links/arm-links/src/models/resourceLinksMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/links/arm-links/src/operations/index.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is

sdk/links/arm-links/src/operations/operations.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is
@@ -108,6 +107,9 @@ const listNextOperationSpec: msRest.OperationSpec = {
   urlParameters: [
     Parameters.nextPageLink
   ],
+  queryParameters: [
+    Parameters.apiVersion
+  ],
   headerParameters: [
     Parameters.acceptLanguage
   ],

sdk/links/arm-links/src/operations/resourceLinks.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is
@@ -199,7 +198,7 @@ export class ResourceLinks {
    * @param [options] The optional parameters
    * @returns Promise<Models.ResourceLinksListAtSubscriptionNextResponse>
    */
-  listAtSubscriptionNext(nextPageLink: string, options?: msRest.RequestOptionsBase): Promise<Models.ResourceLinksListAtSubscriptionNextResponse>;
+  listAtSubscriptionNext(nextPageLink: string, options?: Models.ResourceLinksListAtSubscriptionNextOptionalParams): Promise<Models.ResourceLinksListAtSubscriptionNextResponse>;
   /**
    * @param nextPageLink The NextLink from the previous successful call to List operation.
    * @param callback The callback
@@ -210,8 +209,8 @@ export class ResourceLinks {
    * @param options The optional parameters
    * @param callback The callback
    */
-  listAtSubscriptionNext(nextPageLink: string, options: msRest.RequestOptionsBase, callback: msRest.ServiceCallback<Models.ResourceLinkResult>): void;
-  listAtSubscriptionNext(nextPageLink: string, options?: msRest.RequestOptionsBase | msRest.ServiceCallback<Models.ResourceLinkResult>, callback?: msRest.ServiceCallback<Models.ResourceLinkResult>): Promise<Models.ResourceLinksListAtSubscriptionNextResponse> {
+  listAtSubscriptionNext(nextPageLink: string, options: Models.ResourceLinksListAtSubscriptionNextOptionalParams, callback: msRest.ServiceCallback<Models.ResourceLinkResult>): void;
+  listAtSubscriptionNext(nextPageLink: string, options?: Models.ResourceLinksListAtSubscriptionNextOptionalParams | msRest.ServiceCallback<Models.ResourceLinkResult>, callback?: msRest.ServiceCallback<Models.ResourceLinkResult>): Promise<Models.ResourceLinksListAtSubscriptionNextResponse> {
     return this.client.sendOperationRequest(
       {
         nextPageLink,
@@ -227,7 +226,7 @@ export class ResourceLinks {
    * @param [options] The optional parameters
    * @returns Promise<Models.ResourceLinksListAtSourceScopeNextResponse>
    */
-  listAtSourceScopeNext(nextPageLink: string, options?: msRest.RequestOptionsBase): Promise<Models.ResourceLinksListAtSourceScopeNextResponse>;
+  listAtSourceScopeNext(nextPageLink: string, options?: Models.ResourceLinksListAtSourceScopeNextOptionalParams): Promise<Models.ResourceLinksListAtSourceScopeNextResponse>;
   /**
    * @param nextPageLink The NextLink from the previous successful call to List operation.
    * @param callback The callback
@@ -238,8 +237,8 @@ export class ResourceLinks {
    * @param options The optional parameters
    * @param callback The callback
    */
-  listAtSourceScopeNext(nextPageLink: string, options: msRest.RequestOptionsBase, callback: msRest.ServiceCallback<Models.ResourceLinkResult>): void;
-  listAtSourceScopeNext(nextPageLink: string, options?: msRest.RequestOptionsBase | msRest.ServiceCallback<Models.ResourceLinkResult>, callback?: msRest.ServiceCallback<Models.ResourceLinkResult>): Promise<Models.ResourceLinksListAtSourceScopeNextResponse> {
+  listAtSourceScopeNext(nextPageLink: string, options: Models.ResourceLinksListAtSourceScopeNextOptionalParams, callback: msRest.ServiceCallback<Models.ResourceLinkResult>): void;
+  listAtSourceScopeNext(nextPageLink: string, options?: Models.ResourceLinksListAtSourceScopeNextOptionalParams | msRest.ServiceCallback<Models.ResourceLinkResult>, callback?: msRest.ServiceCallback<Models.ResourceLinkResult>): Promise<Models.ResourceLinksListAtSourceScopeNextResponse> {
     return this.client.sendOperationRequest(
       {
         nextPageLink,
@@ -385,6 +384,10 @@ const listAtSubscriptionNextOperationSpec: msRest.OperationSpec = {
   urlParameters: [
     Parameters.nextPageLink
   ],
+  queryParameters: [
+    Parameters.filter,
+    Parameters.apiVersion
+  ],
   headerParameters: [
     Parameters.acceptLanguage
   ],
@@ -406,6 +409,10 @@ const listAtSourceScopeNextOperationSpec: msRest.OperationSpec = {
   urlParameters: [
     Parameters.nextPageLink
   ],
+  queryParameters: [
+    Parameters.filter,
+    Parameters.apiVersion
+  ],
   headerParameters: [
     Parameters.acceptLanguage
   ],

sdk/links/arm-links/tsconfig.json

@@ -9,7 +9,7 @@
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
-    "lib": ["es6"],
+    "lib": ["es6", "dom"],
     "declaration": true,
     "outDir": "./esm",
     "importHelpers": true

sdk/servicebus/service-bus/review/service-bus.api.md

@@ -5,7 +5,6 @@
 ```ts
 
 import { AmqpAnnotatedMessage } from '@azure/core-amqp';
-import { AmqpError } from 'rhea-promise';
 import { delay } from '@azure/core-amqp';
 import { Delivery } from 'rhea-promise';
 import { HttpResponse } from '@azure/core-http';
@@ -136,7 +135,7 @@ export interface GetMessageIteratorOptions extends OperationOptionsBase {
 }
 
 // @public
-export function isServiceBusError(err: Error | AmqpError | ServiceBusError): err is ServiceBusError;
+export function isServiceBusError(err: any): err is ServiceBusError;
 
 // @public
 export interface MessageHandlers {

sdk/servicebus/service-bus/src/serviceBusError.ts

@@ -172,8 +172,6 @@ export function translateServiceBusError(err: AmqpError | Error): ServiceBusErro
  *
  * @param err An error to check to see if it's of type ServiceBusError
  */
-export function isServiceBusError(
-  err: Error | AmqpError | ServiceBusError
-): err is ServiceBusError {
-  return (err as Error | ServiceBusError).name === "ServiceBusError";
+export function isServiceBusError(err: any): err is ServiceBusError {
+  return err?.name === "ServiceBusError";
 }