[AutoPR @azure/arm-avs] fix AVS 2020-03-20 correctness errors for empty body and internet default

sdk/avs/arm-avs/README.md

@@ -15,7 +15,7 @@ npm install @azure/arm-avs
 
 ### How to use
 
-#### nodejs - Authentication, client creation and list operations as an example written in TypeScript.
+#### nodejs - client creation and list operations as an example written in TypeScript.
 
 ##### Install @azure/ms-rest-nodeauth
 
@@ -26,11 +26,10 @@ npm install @azure/ms-rest-nodeauth@"^3.0.0"
 
 ##### Sample code
 
+While the below sample uses the interactive login, other authentication options can be found in the [README.md file of @azure/ms-rest-nodeauth](https://www.npmjs.com/package/@azure/ms-rest-nodeauth) package
 ```typescript
-import * as msRest from "@azure/ms-rest-js";
-import * as msRestAzure from "@azure/ms-rest-azure-js";
-import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
-import { AvsClient, AvsModels, AvsMappers } from "@azure/arm-avs";
+const msRestNodeAuth = require("@azure/ms-rest-nodeauth");
+const { AvsClient } = require("@azure/arm-avs");
 const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
 
 msRestNodeAuth.interactiveLogin().then((creds) => {

sdk/avs/arm-avs/package.json

@@ -2,7 +2,7 @@
   "name": "@azure/arm-avs",
   "author": "Microsoft Corporation",
   "description": "AvsClient Library with typescript type definitions for node.js and browser.",
-  "version": "1.0.0",
+  "version": "0.1.0",
   "dependencies": {
     "@azure/ms-rest-azure-js": "^2.0.1",
     "@azure/ms-rest-js": "^2.0.4",

sdk/avs/arm-avs/rollup.config.js

@@ -21,8 +21,8 @@ const config = {
       "@azure/ms-rest-azure-js": "msRestAzure"
     },
     banner: `/*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/avs/arm-avs/src/avsClient.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is

sdk/avs/arm-avs/src/avsClientContext.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is
@@ -13,7 +12,7 @@ import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 
 const packageName = "@azure/arm-avs";
-const packageVersion = "1.0.0";
+const packageVersion = "0.1.0";
 
 export class AvsClientContext extends msRestAzure.AzureServiceClient {
   credentials: msRest.ServiceClientCredentials;
@@ -37,7 +36,7 @@ export class AvsClientContext extends msRestAzure.AzureServiceClient {
     if (!options) {
       options = {};
     }
-    if (!options.userAgent) {
+    if(!options.userAgent) {
       const defaultUserAgent = msRestAzure.getDefaultUserAgentValue();
       options.userAgent = `${packageName}/${packageVersion} ${defaultUserAgent}`;
     }
@@ -52,10 +51,10 @@ export class AvsClientContext extends msRestAzure.AzureServiceClient {
     this.credentials = credentials;
     this.subscriptionId = subscriptionId;
 
-    if (options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
+    if(options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
       this.acceptLanguage = options.acceptLanguage;
     }
-    if (options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
+    if(options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
       this.longRunningOperationRetryTimeout = options.longRunningOperationRetryTimeout;
     }
   }

sdk/avs/arm-avs/src/models/authorizationsMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/avs/arm-avs/src/models/clustersMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/avs/arm-avs/src/models/hcxEnterpriseSitesMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.

sdk/avs/arm-avs/src/models/index.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
@@ -95,7 +95,9 @@ export interface ErrorAdditionalInfo {
 }
 
 /**
- * The resource management error response.
+ * Common error response for all Azure Resource Manager APIs to return error details for failed
+ * operations. (This also follows the OData error response format.)
+ * @summary Error Response
  */
 export interface ErrorResponse {
   /**
@@ -151,6 +153,122 @@ export interface OperationDisplay {
   readonly description?: string;
 }
 
+/**
+ * Specifications of the Log for Azure Monitoring
+ */
+export interface LogSpecification {
+  /**
+   * Name of the log
+   */
+  name?: string;
+  /**
+   * Localized friendly display name of the log
+   */
+  displayName?: string;
+  /**
+   * Blob duration of the log
+   */
+  blobDuration?: string;
+}
+
+/**
+ * Specifications of the Dimension of metrics
+ */
+export interface MetricDimension {
+  /**
+   * Name of the dimension
+   */
+  name?: string;
+  /**
+   * Localized friendly display name of the dimension
+   */
+  displayName?: string;
+}
+
+/**
+ * Specifications of the Metrics for Azure Monitoring
+ */
+export interface MetricSpecification {
+  /**
+   * Name of the metric
+   */
+  name?: string;
+  /**
+   * Localized friendly display name of the metric
+   */
+  displayName?: string;
+  /**
+   * Localized friendly description of the metric
+   */
+  displayDescription?: string;
+  /**
+   * Unit that makes sense for the metric
+   */
+  unit?: string;
+  /**
+   * Name of the metric category that the metric belongs to. A metric can only belong to a single
+   * category.
+   */
+  category?: string;
+  /**
+   * Only provide one value for this field. Valid values: Average, Minimum, Maximum, Total, Count.
+   */
+  aggregationType?: string;
+  /**
+   * Supported aggregation types
+   */
+  supportedAggregationTypes?: string[];
+  /**
+   * Supported time grain types
+   */
+  supportedTimeGrainTypes?: string[];
+  /**
+   * Optional. If set to true, then zero will be returned for time duration where no metric is
+   * emitted/published.
+   */
+  fillGapWithZero?: boolean;
+  /**
+   * Dimensions of the metric
+   */
+  dimensions?: MetricDimension[];
+  /**
+   * Whether or not the service is using regional MDM accounts.
+   */
+  enableRegionalMdmAccount?: string;
+  /**
+   * The name of the MDM account.
+   */
+  sourceMdmAccount?: string;
+  /**
+   * The name of the MDM namespace.
+   */
+  sourceMdmNamespace?: string;
+}
+
+/**
+ * Service specification payload
+ */
+export interface ServiceSpecification {
+  /**
+   * Specifications of the Log for Azure Monitoring
+   */
+  logSpecifications?: LogSpecification[];
+  /**
+   * Specifications of the Metrics for Azure Monitoring
+   */
+  metricSpecifications?: MetricSpecification[];
+}
+
+/**
+ * Extra Operation properties
+ */
+export interface OperationProperties {
+  /**
+   * Service specifications of the operation
+   */
+  serviceSpecification?: ServiceSpecification;
+}
+
 /**
  * A REST API operation
  */
@@ -165,6 +283,18 @@ export interface Operation {
    * **NOTE: This property will not be serialized. It can only be populated by the server.**
    */
   readonly display?: OperationDisplay;
+  /**
+   * Gets or sets a value indicating whether the operation is a data action or not
+   */
+  isDataAction?: boolean;
+  /**
+   * Origin of the operation
+   */
+  origin?: string;
+  /**
+   * Properties of the operation
+   */
+  properties?: OperationProperties;
 }
 
 /**
@@ -309,7 +439,7 @@ export interface PrivateCloud extends TrackedResource {
   managementCluster?: ManagementCluster;
   /**
    * Connectivity to internet is enabled or disabled. Possible values include: 'Enabled',
-   * 'Disabled'
+   * 'Disabled'. Default value: 'Disabled'.
    */
   internet?: InternetEnum;
   /**
@@ -386,6 +516,11 @@ export interface ClusterUpdateProperties {
  * The properties of a default cluster
  */
 export interface ManagementCluster extends ClusterUpdateProperties {
+  /**
+   * The state of the cluster provisioning. Possible values include: 'Succeeded', 'Failed',
+   * 'Cancelled', 'Deleting', 'Updating'
+   */
+  provisioningState?: ClusterProvisioningState;
   /**
    * The identity
    * **NOTE: This property will not be serialized. It can only be populated by the server.**
@@ -412,7 +547,7 @@ export interface PrivateCloudUpdate {
   managementCluster?: ManagementCluster;
   /**
    * Connectivity to internet is enabled or disabled. Possible values include: 'Enabled',
-   * 'Disabled'
+   * 'Disabled'. Default value: 'Disabled'.
    */
   internet?: InternetEnum;
   /**
@@ -433,6 +568,11 @@ export interface Cluster extends Resource {
    * The cluster size
    */
   clusterSize?: number;
+  /**
+   * The state of the cluster provisioning. Possible values include: 'Succeeded', 'Failed',
+   * 'Cancelled', 'Deleting', 'Updating'
+   */
+  provisioningState?: ClusterProvisioningState;
   /**
    * The identity
    * **NOTE: This property will not be serialized. It can only be populated by the server.**
@@ -443,12 +583,6 @@ export interface Cluster extends Resource {
    * **NOTE: This property will not be serialized. It can only be populated by the server.**
    */
   readonly hosts?: string[];
-  /**
-   * The state of the cluster provisioning. Possible values include: 'Succeeded', 'Failed',
-   * 'Cancelled', 'Deleting', 'Updating'
-   * **NOTE: This property will not be serialized. It can only be populated by the server.**
-   */
-  readonly provisioningState?: ClusterProvisioningState;
 }
 
 /**
@@ -638,20 +772,20 @@ export type SslEnum = 'Enabled' | 'Disabled';
 export type PrivateCloudProvisioningState = 'Succeeded' | 'Failed' | 'Cancelled' | 'Pending' | 'Building' | 'Deleting' | 'Updating';
 
 /**
- * Defines values for InternetEnum.
- * Possible values include: 'Enabled', 'Disabled'
+ * Defines values for ClusterProvisioningState.
+ * Possible values include: 'Succeeded', 'Failed', 'Cancelled', 'Deleting', 'Updating'
  * @readonly
  * @enum {string}
  */
-export type InternetEnum = 'Enabled' | 'Disabled';
+export type ClusterProvisioningState = 'Succeeded' | 'Failed' | 'Cancelled' | 'Deleting' | 'Updating';
 
 /**
- * Defines values for ClusterProvisioningState.
- * Possible values include: 'Succeeded', 'Failed', 'Cancelled', 'Deleting', 'Updating'
+ * Defines values for InternetEnum.
+ * Possible values include: 'Enabled', 'Disabled'
  * @readonly
  * @enum {string}
  */
-export type ClusterProvisioningState = 'Succeeded' | 'Failed' | 'Cancelled' | 'Deleting' | 'Updating';
+export type InternetEnum = 'Enabled' | 'Disabled';
 
 /**
  * Defines values for HcxEnterpriseSiteStatus.

sdk/avs/arm-avs/src/models/locationsMappers.ts

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.