[AutoPR @azure/arm-maps] [Hub Generated] Review request for Microsoft.Maps to add Creator resource under version preview/2020-02-01-preview

sdk/maps/arm-maps/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Microsoft
+Copyright (c) 2020 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/maps/arm-maps/README.md

@@ -9,7 +9,7 @@ This package contains an isomorphic SDK for MapsManagementClient.
 
 ### How to Install
 
-```
+```bash
 npm install @azure/arm-maps
 ```
 
@@ -19,13 +19,14 @@ npm install @azure/arm-maps
 
 ##### Install @azure/ms-rest-nodeauth
 
-```
-npm install @azure/ms-rest-nodeauth
+- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
+```bash
+npm install @azure/ms-rest-nodeauth@"^3.0.0"
 ```
 
 ##### Sample code
 
-```ts
+```typescript
 import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
@@ -49,7 +50,7 @@ msRestNodeAuth.interactiveLogin().then((creds) => {
 
 ##### Install @azure/ms-rest-browserauth
 
-```
+```bash
 npm install @azure/ms-rest-browserauth
 ```
 
@@ -99,5 +100,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
 
 - [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)
 
-
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Fmaps%2Farm-maps%2FREADME.png)
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/maps/arm-maps/README.png)

sdk/maps/arm-maps/package.json

@@ -4,9 +4,9 @@
   "description": "MapsManagementClient Library with typescript type definitions for node.js and browser.",
   "version": "1.1.0",
   "dependencies": {
-    "@azure/ms-rest-azure-js": "^1.1.0",
-    "@azure/ms-rest-js": "^1.1.0",
-    "tslib": "^1.9.3"
+    "@azure/ms-rest-azure-js": "^2.0.1",
+    "@azure/ms-rest-js": "^2.0.4",
+    "tslib": "^1.10.0"
   },
   "keywords": [
     "node",
@@ -20,18 +20,19 @@
   "module": "./esm/mapsManagementClient.js",
   "types": "./esm/mapsManagementClient.d.ts",
   "devDependencies": {
-    "typescript": "^3.1.1",
-    "rollup": "^0.66.2",
-    "rollup-plugin-node-resolve": "^3.4.0",
-    "uglify-js": "^3.4.9"
+    "typescript": "^3.5.3",
+    "rollup": "^1.18.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
+    "rollup-plugin-sourcemaps": "^0.4.2",
+    "uglify-js": "^3.6.0"
   },
-  "homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/sdk/maps/arm-maps",
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/maps/arm-maps",
   "repository": {
     "type": "git",
-    "url": "https://github.com/azure/azure-sdk-for-js.git"
+    "url": "https://github.com/Azure/azure-sdk-for-js.git"
   },
   "bugs": {
-    "url": "https://github.com/azure/azure-sdk-for-js/issues"
+    "url": "https://github.com/Azure/azure-sdk-for-js/issues"
   },
   "files": [
     "dist/**/*.js",
@@ -43,6 +44,7 @@
     "esm/**/*.d.ts",
     "esm/**/*.d.ts.map",
     "src/**/*.ts",
+    "README.md",
     "rollup.config.js",
     "tsconfig.json"
   ],

sdk/maps/arm-maps/rollup.config.js

@@ -1,10 +1,16 @@
+import rollup from "rollup";
 import nodeResolve from "rollup-plugin-node-resolve";
+import sourcemaps from "rollup-plugin-sourcemaps";
+
 /**
- * @type {import('rollup').RollupFileOptions}
+ * @type {rollup.RollupFileOptions}
  */
 const config = {
-  input: './esm/mapsManagementClient.js',
-  external: ["@azure/ms-rest-js", "@azure/ms-rest-azure-js"],
+  input: "./esm/mapsManagementClient.js",
+  external: [
+    "@azure/ms-rest-js",
+    "@azure/ms-rest-azure-js"
+  ],
   output: {
     file: "./dist/arm-maps.js",
     format: "umd",
@@ -16,16 +22,16 @@ const config = {
     },
     banner: `/*
  * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Licensed under the MIT License. See License.txt in the project root for license information.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is
- * regenerated.
+ * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */`
   },
   plugins: [
-    nodeResolve({ module: true })
+    nodeResolve({ mainFields: ['module', 'main'] }),
+    sourcemaps()
   ]
 };
+
 export default config;

sdk/maps/arm-maps/src/mapsManagementClient.ts

@@ -18,17 +18,22 @@ import { MapsManagementClientContext } from "./mapsManagementClientContext";
 class MapsManagementClient extends MapsManagementClientContext {
   // Operation groups
   accounts: operations.Accounts;
+  maps: operations.Maps;
+  privateAtlases: operations.PrivateAtlases;
+  creators: operations.Creators;
 
   /**
    * Initializes a new instance of the MapsManagementClient class.
    * @param credentials Credentials needed for the client to connect to Azure.
-   * @param subscriptionId Subscription credentials which uniquely identify Microsoft Azure
-   * subscription. The subscription ID forms part of the URI for every service call.
+   * @param subscriptionId The ID of the target subscription.
    * @param [options] The parameter options
    */
   constructor(credentials: msRest.ServiceClientCredentials, subscriptionId: string, options?: Models.MapsManagementClientOptions) {
     super(credentials, subscriptionId, options);
     this.accounts = new operations.Accounts(this);
+    this.maps = new operations.Maps(this);
+    this.privateAtlases = new operations.PrivateAtlases(this);
+    this.creators = new operations.Creators(this);
   }
 }
 

sdk/maps/arm-maps/src/mapsManagementClientContext.ts

@@ -13,7 +13,7 @@ import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 
 const packageName = "@azure/arm-maps";
-const packageVersion = "0.1.0";
+const packageVersion = "1.1.0";
 
 export class MapsManagementClientContext extends msRestAzure.AzureServiceClient {
   credentials: msRest.ServiceClientCredentials;
@@ -23,8 +23,7 @@ export class MapsManagementClientContext extends msRestAzure.AzureServiceClient
   /**
    * Initializes a new instance of the MapsManagementClient class.
    * @param credentials Credentials needed for the client to connect to Azure.
-   * @param subscriptionId Subscription credentials which uniquely identify Microsoft Azure
-   * subscription. The subscription ID forms part of the URI for every service call.
+   * @param subscriptionId The ID of the target subscription.
    * @param [options] The parameter options
    */
   constructor(credentials: msRest.ServiceClientCredentials, subscriptionId: string, options?: Models.MapsManagementClientOptions) {
@@ -45,7 +44,7 @@ export class MapsManagementClientContext extends msRestAzure.AzureServiceClient
 
     super(credentials, options);
 
-    this.apiVersion = '2018-05-01';
+    this.apiVersion = '2020-02-01-preview';
     this.acceptLanguage = 'en-US';
     this.longRunningOperationRetryTimeout = 30;
     this.baseUri = options.baseUri || this.baseUri || "https://management.azure.com";

sdk/maps/arm-maps/src/models/accountsMappers.ts

@@ -1,28 +1,31 @@
 /*
  * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Licensed under the MIT License. See License.txt in the project root for license information.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is
- * regenerated.
+ * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
 export {
-  MapsAccountCreateParameters,
-  Sku,
-  MapsAccount,
-  Resource,
+  AzureEntityResource,
   BaseResource,
-  ErrorModel,
-  ErrorDetailsItem,
-  MapsAccountUpdateParameters,
-  MapsAccounts,
-  MapsAccountsMoveRequest,
+  Creator,
+  CreatorProperties,
+  ErrorAdditionalInfo,
+  ErrorResponse,
+  ErrorResponseError,
+  MapsAccount,
+  MapsAccountCreateParameters,
   MapsAccountKeys,
+  MapsAccountProperties,
+  MapsAccounts,
+  MapsAccountUpdateParameters,
   MapsKeySpecification,
-  MapsOperations,
-  MapsOperationsValueItem,
-  MapsOperationsValueItemDisplay
+  PrivateAtlas,
+  PrivateAtlasProperties,
+  ProxyResource,
+  Resource,
+  Sku,
+  SystemData,
+  TrackedResource
 } from "../models/mappers";
-

sdk/maps/arm-maps/src/models/creatorsMappers.ts

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License. See License.txt in the project root for license information.
+ *
+ * Code generated by Microsoft (R) AutoRest Code Generator.
+ * Changes may cause incorrect behavior and will be lost if the code is regenerated.
+ */
+
+export {
+  AzureEntityResource,
+  BaseResource,
+  Creator,
+  CreatorCreateParameters,
+  CreatorList,
+  CreatorProperties,
+  CreatorUpdateParameters,
+  ErrorAdditionalInfo,
+  ErrorResponse,
+  ErrorResponseError,
+  MapsAccount,
+  MapsAccountProperties,
+  PrivateAtlas,
+  PrivateAtlasProperties,
+  ProxyResource,
+  Resource,
+  Sku,
+  SystemData,
+  TrackedResource
+} from "../models/mappers";