Updates for new RP data models #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djyou
commented
Oct 28, 2016
djyou
commented
- Updated SDK.
- Changed storage account update as part of "az acr update" command. Removed storage subgroup.
- Removed client side validation on registry name and storage account. Added a separate "az acr check-name" command to check name availability.
- Updated format to match new models.
- Changed "az acr list" command from ARM list to RP list.
- Added regenerate admin user credental command.
Author
|
It looks good to me. Since it's a big PR let's wait for a 2nd reviewer in case I missed something. |
1. Updated SDK. 2. Changed storage account update as part of "az acr update" command. Removed storage subgroup. 3. Removed client side validation on registry name and storage account. Added a separate "az acr check-name" command to check name availability. 4. Updated format to match new models. 5. Changed "az acr list" command from ARM list to RP list. 6. Added regenerate admin user credental command.
djyou
pushed a commit
that referenced
this pull request
Sep 25, 2017
* Initial support for VM and single zone VMSS (#14) * wire up the initial zone support work * add output * add tests * disable package verifications * use a private copy of network sdk with zone support (#15) * Support for zoned public IP. Make global zone_type and zones_type. (#16) * Support for zoned public IP. Make global zone_type and zones_type. * Code review feedback. * apply api version range on vm zone test (#19) * show zone in the table output (#20) * install: support to build out a msi installer from local sources (#17) * doc:add command examples using availability zones (#21) * Installer: build debian bundle from a local clone (#28) * skip a few expeneive travis builds * test: update tests to work with new azure-mgmt-compute with zone support * network: support zone in network lb create (#37) * VNet peering examples. (#51) * Add BrazilUS and Dogfood cloud config files. (#50) * undo all changes specifically for private repository * fix help per review feedback * fix lint error * use newer nrp sdk version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.