Skip to content

Conversation

@finiteattractor
Copy link

Adding new API version (2017-05-15-preview). No other changes made, just copied all files and updated the version string.

…ust copied all files and updated the version string.
Copy link

@viveklingaiah viveklingaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will need to another block for api 2017-05-15-preview like this file has for 2015
https://github.com/AzureAutomationTeam/azure-rest-api-specs/blob/current/specification/automation/resource-manager/readme.md

so, that you can pass an argument for 2017 and generates SDK for you. Could you also try generating SDK using autorest. Weijie did it last week, please check with him for commands for SDK generation and linter (static validation)

@safeermohammed
Copy link

@finiteattractor we can close this PR as this is not needed

- Small refactoring to schedule model definition so i can share it.
- Added new software update configuration specs
- Updating examples path
- Renamed some definitions to match resource
- Fixing invalid references
- Fixed example file name
- Added two resources to readme.md file
- consolidated common properties (lastmodified/created-time/by)
},
"scheduleFrequency": {
"type": "string",
"description": "Gets or sets the frequency of the schedule.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In last review Azure team were against using gets and sets. Can you change the description

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated all! Thanks!

@viveklingaiah
Copy link

Hi Mo,
Make sure you do not have descriptions starting with "gets or sets" for definitions, they need to be more descriptive and useful. Swagger team will block, otherwise. I believe you said you've already corrected ? Also, could you replace real subscription ids in examples with some dummy id. or "subid" or all zeros ? Swagger team will raise concerns for that as well. refer to an example for accounts or runbook

@viveklingaiah
Copy link

I can approve right now or you can change and then I approve.
let me know

@finiteattractor finiteattractor merged commit a32938a into current Oct 30, 2017
finiteattractor added a commit that referenced this pull request Nov 14, 2017
* added extension properties to Get & GetNode

* fix indentation

* fix indentation

* changed description text

* Adding new API version (2017-05-15-preview). No other changes made (#2)

Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. 

- Added resources:
 - SoftwareUpdateConfiguration
 - SoftwareUpdateConfigurationRun
 - SoftwareUpdateConfigurationMachineRun

- Validations:
 - Autorest azure validations passed
  - x-ms-examples validated with no errors

* Updated tag in global configuration

Updated tag in global configuration to use the latest api version as per azure PR review comment
finiteattractor added a commit that referenced this pull request Dec 5, 2017
* added extension properties to Get & GetNode

* fix indentation

* fix indentation

* changed description text

* Adding new API version (2017-05-15-preview). No other changes made (#2)

Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. 

- Added resources:
 - SoftwareUpdateConfiguration
 - SoftwareUpdateConfigurationRun
 - SoftwareUpdateConfigurationMachineRun

- Validations:
 - Autorest azure validations passed
  - x-ms-examples validated with no errors

* Updated tag in global configuration

Updated tag in global configuration to use the latest api version as per azure PR review comment

* - Fixed 2 typos in URLs (#4)

- Moved parameters inside operations as it was not showing properly in documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants