Skip to content

Conversation

@bavneetsingh16
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

bewatersmsft and others added 30 commits October 1, 2025 15:48
* Azure Firewall Autoscale Configuration

* bump version

* update recordings for tests

* reset of recordings

* Try to fix recording for test_azure_firewall_policy_explicit_proxy

* non-dynamic test value

* Use sas token key

* Remove explicit proxy test
…the API. (Azure#9266)

* Removing unsupported commands from the managednetworkfabric CLI.

* updating history
mark operations stable

update setup.py and HISTORY.rst

remove azext.isPreview from azext_metadata.json
)

* Adding new parameter enable-dnstap-logging

* Small nit

* Small nit2

* Remove comma

* Update history

* update test recording

* Update setup

---------

Co-authored-by: Bhumika Kaur Matharu <[email protected]>
* skip none overrides on localdns profile

* update history rst

* refactor to process dns overrides func

* move overrides function to helper file

* apply linter suggestions

* add localdnsconfig folder

* add more tests

* add new json files

* add default dns overrides

* add more test cases

* move tests around, move invalid cases to another file

* add back import semver

* reorder the existing tests

* delete preferred mode only

* delete null.json

* remove redundant json file

* remove redundant json file

* fix the mistake at line 3349

* forgot that i put all the configs in data/localconfig folder

* remove unused file

* spelling error

* fix default dnsOverrides check when we create agentpool with required mode only

* restore localdnsconfig file

* delete extra property case from invalid test file

* add extra property cases in src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

* add extra property files

* check for defaulted *dnsOverrides when making agent pool with mode: required only

* comment out cleanup in test_aks_nodepool_add_with_localdns_required_mode

* add more logging for debugging

* add print statements in src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/operations/_agent_pools_operations.py for debugging

* only initialize the dictionaries if dnsoverrides are provided

* process dns overrides only when dns overrides are provided

* consolidate duplicated build_localdns_profile function

* move invalid cases to line 4133

* update test_aks_commands.py

* look for vnetDnsOverrides and kubeDNSOverrides keys, case-insensitive

* fix test_aks_nodepool_add_with_localdns_required_mode_single_vnetdns

* check for dictionary for build_override

* update failing test cases

* rename from required_mode_extra_property.json -> required_mode_kubedns_extra_property.json

* fix azdev style

* temporarily add self.fail statements s.t. i can see the error_message

* change from assertTrue to assertIn with more specific error msg, delete un-needed test case

* change from print to debug

* remove logger.debug line to print localdnsprofile

* add null config file

* fix the tests

* fix the tests

* update src/aks-preview/HISTORY.rst with a new note under 18.0.0b42

* update src/aks-preview/HISTORY.rst

* Revert "add print statements in src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/operations/_agent_pools_operations.py for debugging"

This reverts commit b747438.

* update src/aks-preview/HISTORY.rst

* Revert "add more logging for debugging"

This reverts commit 1786254.

* mix the casing for *dnsoverrides

* throw an exception from cli if the values of kubednsoverrides or vnetdnsoverrides are not type dict

* add tests for null and non-dict overrides

* make the keys of localdnsprofile mixed-case

* add required_mode_null_dnsOverrides.json and required_mode_number_dnsOverrides.json

* correct the error message I'm looking for, for non-dict dns overrides

* remove print stmt from src/aks-preview/azext_aks_preview/_helpers.py

* add check for DNS override settings

* update the test with dns override settings check

* update assertIn msg for test_aks_nodepool_add_with_localdns_required_mode_partial_invalid

* break down InvalidArgumentValueError msg into two lines

* update existing cassette files

* new cassette files for new tests

* add three additional cassette files I did not commit before

* expect InvalidArgumentValueError when None is provided for DNS overrides

* update AKSPreviewAgentPoolUpdateDecoratorCommonTestCase.common_update_localdns_profile

* revert the import statement for from azure.cli.command_modules.acs.tests.latest.mocks import

* Add a new line

* Revert "Add a new line"

This reverts commit 2c347c3.

* update version in src/aks-preview/setup.py to align with azure-cli-extensions/src/aks-preview/HISTORY.rst

---------

Co-authored-by: juanbe <[email protected]>
Co-authored-by: Juan Diego Bencardino <[email protected]>
* Add changes related 2024-10-01

* Update changelog

* Update tests

* Updated tests

* updated tests recordings

* Update test recordings
* bump to 1.6.5

* update the version to 1.7.0
* breaking change warning

* Update src/redisenterprise/_breaking_change.py

Co-authored-by: Copilot <[email protected]>

* style fix

* update version

---------

Co-authored-by: Nikita Garg <[email protected]>
Co-authored-by: Copilot <[email protected]>
* Added SQL DB Retry, SQLVM Delete and SQLMI Delete commands

* Updates.

* Updates

---------

Co-authored-by: Amarjeet Kumar <[email protected]>
* hide the --enable-managed-system-pool optoin for now

* add history

* keep _help.py

* fix style

* update setup.py

---------

Co-authored-by: Hao Yuan <[email protected]>
Azure#9282)

* Removing unsupported commands from the managednetworkfabric CLI.

* updating history

* Network Cloud CLi - Fixing zip-slip vulnerability

* updating history and setup.py versions

* linting fixes
…9203)

* Add a warning and path for default change for stdio

* Satisfy azdev style

* Fix help string for --enable-stdio

* Refactor resolving stdio into it's own function

* Bump version

* Bump minor version
* base recalibration

update

update

update

update

update

update

removing 0401

got tests to work

update

pylint

update

pylint

update

adding get credential commansd

update

pylint

addressing comments

simplifying namespace

updates

updates

lint

style

pylint

updates

updates to member

updates

updates

updates

style

updates

update

update

updated test recordings

removing unwanted files

updates

updating metadata

linter

updating version/history

setup

updates

style

style

update style

flake8

remove preview

making hubful recording use global endpoint

squash-managednamespace implementation

* changing defaults, updating help message

* updates

* adding validation none check

* updates

* version

---------

Co-authored-by: audrastump <[email protected]>
Co-authored-by: Jim Minter <[email protected]>
azclibot and others added 26 commits October 13, 2025 02:51
…tion` to enable KMS infrastructure encryption on an existing cluster. (Azure#9287)
* vendor SDK

* Update SDK reference

* Fix test
* update file loc

* update version

* style fix

* style fix

---------

Co-authored-by: Nikita Garg <[email protected]>
* Removing unsupported commands from the managednetworkfabric CLI.

* updating history

* Network Cloud CLi - Fixing zip-slip vulnerability

* updating history and setup.py versions

* linting fixes

* Netowrk Cloud CLI version 2025-09-01 GA
* release 24-11

* update tests

* update version

* fix version number

* fix style

* fix style issue

* update tests

* update tests

* update tests

* update tests

* update tests

* upate test

* update test

* update test

* update test

* update commands

* update

* Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_show.py

Co-authored-by: Copilot <[email protected]>

* Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_list.py

Co-authored-by: Copilot <[email protected]>

* update tests

* update

* update test

* update

* update

---------

Co-authored-by: Copilot <[email protected]>
* forcedelete

* format

* add code owner

* mypy
…add E2E coverage and improve logging (#20)

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* Parameterize for airgapped clouds (#5)

* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>

* Oras client fix to work with different MCRs (#6)

Co-authored-by: mmcneal <[email protected]>

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* Update cluster diagnostics image to 1.29.3 (#7)

* Update cluster diagnostics helm chart to 1.29.3

* Fix lint issues

---------

Co-authored-by: bgriddaluru <[email protected]>

* RBAC deprecation & fix the issue

* typo

* fix comments

* update tests

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* rebase

* fix tests

* fix version

* fix mypy, lint

* fix test

* fix test

* fix test

* fix test

* fix test

* rename test

* deprecate flags

* rebase

* rebase

* bump version for release

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Atchut Kumar Barli <[email protected]>
Co-authored-by: mcnealm13 <[email protected]>
Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>
Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: vithumma <[email protected]>
@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.