Skip to content

Bug Fix for FFX mcr url #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bavneetsingh16 merged 16 commits into from
Oct 15, 2025
Merged

Bug Fix for FFX mcr url #22

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
55c2945
bug fix for ffx
hapate Oct 6, 2025
138a0a5
Updated get_mcr_path
hapate Oct 12, 2025
da75dc5
update get_mcr method invoke
hapate Oct 12, 2025
28ce51a
update get_mcr_path helper method to remove aad endpoint resolve
hapate Oct 12, 2025
f1159ec
Update get_mcr_path invoke
hapate Oct 12, 2025
4c6096e
Update get_mcr_path invoke
hapate Oct 12, 2025
67771c2
Update get_mcr_path invoke
hapate Oct 12, 2025
4fb62dd
Add unit test for geT_mcr_path
hapate Oct 12, 2025
b5db13e
fix test for agc cloud
hapate Oct 12, 2025
7109363
addition test for mc cloud
hapate Oct 15, 2025
23d93d6
Merge branch 'main' into hapate/ffx-mcr-bug-fix
bavneetsingh16 Oct 15, 2025
5fbdd63
fix CI test issues- ruff formatting, linting and delete regex match
Oct 15, 2025
dd3c1f6
Fix MCR postfix to always use '.com'
hapate Oct 15, 2025
f79ffd9
fix CI testcase for mcr path
Oct 15, 2025
b62c8dc
fix ruff formatting
Oct 15, 2025
4013540
Update get_mcr_path for cloud-specific handling
hapate Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/k8s-extension/azext_k8s_extension/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ def get_mcr_path(cmd: CLICommand) -> str:
active_directory_array = cmd.cli_ctx.cloud.endpoints.active_directory.split(".")

@atchutbarli atchutbarli Oct 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a unit test to cover these combinations?


# default for public, mc, ff clouds
mcr_postfix = active_directory_array[2]
mcr_postfix = ".com"

@atchutbarli atchutbarli Oct 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it applicable for mooncake as well?

@thomasyip-msft thomasyip-msft Oct 13, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is.

@atchutbarli atchutbarli Oct 13, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified too,thanks

# special cases for USSec, exclude part of suffix
if len(active_directory_array) == 4 and active_directory_array[2] == "microsoft":
mcr_postfix = active_directory_array[3]
Expand Down
Loading