This repository was archived by the owner on May 13, 2025. It is now read-only.
Adding GA api version 2022-11-01 exposing isSystemExtension and suppo… #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arif-lakhani
requested review from
NarayanThiru,
anagg929,
bavneetsingh16 and
deeksha345
as code owners
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
852a34b to
7cb5215
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
d6365b5 to
39ab7ff
Compare
NarayanThiru
suggested changes
Dec 16, 2022
NarayanThiru
left a comment
NarayanThiru
left a comment
There was a problem hiding this comment.
Just want to confirm - you didn't make any change to the generated files under vendored_sdks, right?
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
5 times, most recently
from
07405ef to
8f526a1
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
84b91d1 to
49e995a
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
4 times, most recently
from
6a16945 to
0bb0b52
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
0bb0b52 to
97c808f
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
0395628 to
3a0fad5
Compare
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
3a0fad5 to
590c891
Compare
NarayanThiru
suggested changes
Jan 19, 2023
src/k8s-extension/azext_k8s_extension/partner_extensions/DataProtectionKubernetes.py
Outdated
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/DefaultExtension.py
Outdated
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/DefaultExtension.py
Outdated
Show resolved
Hide resolved
Arif-lakhani
force-pushed
the
ariflakhani/2022-11-01-GA
branch
from
590c891 to
1b51c5e
Compare
NarayanThiru
approved these changes
Jan 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt for plan info
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.