Repository navigation
Handle missing scope and app permission configuration - #4010
Merged
Iarek Kovtunenko (iarekk) merged 1 commit intoSep 14, 2026
Merged
Iarek Kovtunenko (iarekk) merged 1 commit into
Iarek Kovtunenko (iarekk) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates authorization handlers to fail closed when configured scope or app-permission keys are missing.
Changes:
- Treat missing configuration values as empty requirements.
- Preserve requirement precedence and scope-or-permission OR semantics.
- Add focused coverage for missing configuration scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ScopeAuthorizationHandler.cs |
Handles missing scope values as empty. |
ScopeOrAppPermissionAuthorizationHandler.cs |
Handles missing scope and permission values as empty. |
RequiredScopePolicyTests.cs |
Tests requirement and endpoint missing-scope behavior. |
RequiredScopeOrAppPermissionPolicyTests.cs |
Tests failure and OR-composition behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nilesh Choudhary (4gust)
approved these changes
Aug 31, 2026
Bogdan Gavril (bgavrilMS)
approved these changes
Sep 14, 2026
Bogdan Gavril (bgavrilMS)
force-pushed
the
iinglese/authorization-config-validation-minimal
branch
from
September 14, 2026 11:45
e4e96c2 to
029aa41
Compare
Iarek Kovtunenko (iarekk)
force-pushed
the
iinglese/authorization-config-validation-minimal
branch
from
September 14, 2026 14:52
029aa41 to
4b77cfd
Compare
Iarek Kovtunenko (iarekk)
enabled auto-merge (squash)
September 14, 2026 14:52
Iarek Kovtunenko (iarekk)
force-pushed
the
iinglese/authorization-config-validation-minimal
branch
2 times, most recently
from
September 14, 2026 15:23
2fe530e to
74cfd39
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Iarek Kovtunenko (iarekk)
force-pushed
the
iinglese/authorization-config-validation-minimal
branch
from
September 14, 2026 15:40
74cfd39 to
2cf555e
Compare
Iarek Kovtunenko (iarekk)
deleted the
iinglese/authorization-config-validation-minimal
branch
September 14, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release notes
Authorization now fails when an explicitly configured scope or app-permission key
is missing instead of treating the requirement as undeclared.
Testing