Restore OWIN 5.7.1 packages from internal IDDP feed in PR pipeline#3912
Merged
Conversation
The OWIN project pins Microsoft.IdentityModel WsFederation/Saml to 5.7.1 on ADO agents (TF_BUILD=true). That version is only published to the internal IDDP Azure Artifacts feed, not nuget.org, so restore failed with NU1603 (warning-as-error) on the ephemeral windows-2022 pool. Add the IDDP feed as a package source before the build, reusing the existing NuGetAuthenticate@1 task from template-install-dependencies.yaml for credentials. nuget.org is retained for all other packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the public nuget.org source during the ADO PR build so restore routes solely through the internal IDDP Azure Artifacts feed, which upstreams nuget.org for public packages and serves the internal 5.7.1 IdentityModel packages. Mirrors template-restore-build-MSIdentityWeb.yaml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4gust
approved these changes
Jul 2, 2026
This was referenced Jul 3, 2026
Closed
This was referenced Jul 13, 2026
Closed
Merged
Closed
Closed
Closed
Closed
Open
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the ADO PR pipeline started building the solution on the ephemeral
windows-2022pool (#3911), restore fails with:Microsoft.Identity.Web.OWIN.csprojpins the IdentityModel v5 packages to 5.7.1 whenTF_BUILD=true(i.e. on any ADO agent), otherwise 5.7.0. Version 5.7.1 is only published to the internal IDDP Azure Artifacts feed, not nuget.org — the repoNuGet.Configonly lists nuget.org, so restore can't find it, and repo-wideTreatWarningsAsErrorspromotes NU1603 to an error.Fix
At PR-build time, remove the public nuget.org source and restore exclusively through the internal IDDP feed (
identitydivision/_packaging/IDDP), which upstreams nuget.org for public packages and serves the internal 5.7.1 IdentityModel packages. Credentials come from the existingNuGetAuthenticate@1task already run intemplate-install-dependencies.yaml. This mirrors the established pattern inbuild/template-restore-build-MSIdentityWeb.yaml.NuGet.Configis unchanged, so GitHub Actions / public restores are unaffected.Notes
This assumes the PR pipeline's build identity can authenticate to the IDDP feed (same identitydivision org). If it cannot, we'd fall back to overriding the OWIN package version to the public 5.7.0.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com