credential description extensibility #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tensibility Co-authored-by: jmprieur <[email protected]>
Co-authored-by: jmprieur <[email protected]>
Co-authored-by: jmprieur <[email protected]>
…ders and credential source loaders Co-authored-by: jmprieur <[email protected]>
Co-authored-by: jmprieur <[email protected]>
jmprieur
commented
Sep 23, 2025
jmprieur
changed the title
src/Microsoft.Identity.Web.Certificate/DefaultCertificateLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/DefaultCertificateLoaderTests.cs
Show resolved
Hide resolved
keegan-caruso
approved these changes
Sep 23, 2025
Contributor
keegan-caruso
left a comment
keegan-caruso
left a comment
There was a problem hiding this comment.
Few small suggestions
…r.cs Co-authored-by: Keegan <[email protected]>
…r.CustomSignedAssertion.cs Co-authored-by: Keegan <[email protected]>
bgavrilMS
reviewed
Sep 24, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
Member
bgavrilMS
left a comment
bgavrilMS
left a comment
There was a problem hiding this comment.
Approved with 1 comment about param order
bgavrilMS
approved these changes
Sep 25, 2025
This was referenced Oct 13, 2025
Merged
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extensibility for credential providers in Credential loaders
Fixes #3485 (non-breaking changes way)
Fixes and supersedes: #3486 created by GitHub Copilot