Skip to content

Conversation

@tlupes
Copy link
Contributor

@tlupes tlupes commented Jul 21, 2025

Include the thrown exception in CertificateChangeEventArg

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Add in the thrown exception into CertificateChangeEventArg so that subscriber can know why the change was triggered (in the case of deselection)

Description

We intend to consume this information to emit detailed telemetry about certificate usage failures.

#3427

@tlupes tlupes requested a review from a team as a code owner July 21, 2025 19:34
@tlupes
Copy link
Contributor Author

tlupes commented Jul 21, 2025

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tlupes
but you have merge conflicts (public API files)

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @tlupes

Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, are there any tests to add at this level?

@tlupes
Copy link
Contributor Author

tlupes commented Jul 22, 2025

changes LGTM, are there any tests to add at this level?

There's no clear test that this can be added to, and as this is simply setting a property, I'm not sure of the value of creating a new test just for this.

@keegan-caruso keegan-caruso merged commit c13bed5 into AzureAD:master Jul 23, 2025
5 checks passed
This was referenced Aug 15, 2025
This was referenced Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants