Remove explicit locking in OpenIdConnectCachingSecurityTokenProvider #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
SummarySummary
CoverageNo assemblies have been covered. |
jmprieur
approved these changes
Jan 16, 2025
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
Super elegant!
Thanks @keegan-caruso
SummarySummary
CoverageNo assemblies have been covered. |
jmprieur
deleted the
kecaruso/OpenIdConnectCachingSecurityTokenProvider-locking
branch
This was referenced Aug 1, 2025
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3078
See #3124 and #3118 for more context.
The lock isn't needed if the update is done to the config object itself, since it is a reference type, it will be an atomic update. This removes the need to keep two separate fields in sync.