Skip to content

Conversation

@jmprieur
Copy link
Collaborator

Fix 3167 (package downgrade when referencing IdentityModel.Tokens from dev)

Removed now un-needed reference

Fixes #3167

@jmprieur jmprieur requested a review from a team as a code owner December 16, 2024 19:21
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; extra line.

@pmaytak
Copy link
Contributor

pmaytak commented Dec 16, 2024

@jmprieur The error happened because Identity Web was the one downgrading the package (because of 5x reference) and IdentityModel was referencing the newer one?

@pmaytak pmaytak self-requested a review December 16, 2024 23:16
@jmprieur
Copy link
Collaborator Author

@jmprieur The error happened because Identity Web was the one downgrading the package (because of 5x reference) and IdentityModel was referencing the newer one?

It's happening because CredentialLess exposes only netstandard2.0 -> references Microsoft.Extensions.Logging.Abstractions 2.1 through Mirosoft.IdentityModel..Tokens, but then Credentials exposes all the target frameworks, and therefore we needed to re-reference the right Microsoft.Extensions.Logging.Abstractions version per framework, do avoid the package downgrade in other assemblies.

@jmprieur jmprieur merged commit 9417313 into master Dec 16, 2024
5 checks passed
@jmprieur jmprieur deleted the jmprieur/fixLogginAbstractionsPackageDowngrade branch December 16, 2024 23:57
This was referenced Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IdWeb fails with current version of IdentityModel dev branch

5 participants