Add checks to protect the internal claims used by MIW. Ref: issue #2968 #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce InternalClaimDetectedException in Microsoft.Identity.Web and Microsoft.Identity.Web.OWIN namespaces. This exception is thrown when internal ID Token claims (UniqueTenantIdentifier, UniqueObjectIdentifier) are detected in the user's ID Token. Updated AppBuilderExtension.cs and MicrosoftIdentityWebAppAuthenticationBuilder.cs to check for these claims and throw the exception if found. The new exception class includes a property to store the invalid claim
Contributor
Author
|
@bgavrilMS / @jennyf19 / @jmprieur please review. Thank you! |
Contributor
Author
|
@microsoft-github-policy-service agree |
bgavrilMS
reviewed
Nov 6, 2024
dstamand-msft
left a comment
dstamand-msft
left a comment
There was a problem hiding this comment.
Changes were made in regards to feedback
bgavrilMS
reviewed
Nov 7, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
src/Microsoft.Identity.Web.OWIN/InternalClaimDetectedException.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 8, 2024
src/Microsoft.Identity.Web.OWIN/Microsoft.Identity.Web.OWIN.xml
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 8, 2024
src/Microsoft.Identity.Web.OWIN/InternalClaimDetectedException.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
src/Microsoft.Identity.Web.OWIN/InternalClaimDetectedException.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 8, 2024
src/Microsoft.Identity.Web/WebAppExtensions/MicrosoftIdentityWebAppAuthenticationBuilder.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 8, 2024
msbw2
reviewed
Nov 8, 2024
bgavrilMS
reviewed
Nov 8, 2024
Member
|
LGTM, I only have minor comments and resolving @msbw2 's comments |
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks to protect the users to not use internal claims used by the library
Summary of the changes (Less than 80 chars)
Description
Introduce InternalClaimDetectedException in Microsoft.Identity.Web and Microsoft.Identity.Web.OWIN namespaces. This exception is thrown when internal ID Token claims (UniqueTenantIdentifier, UniqueObjectIdentifier) are detected in the user's ID Token. Updated AppBuilderExtension.cs and MicrosoftIdentityWebAppAuthenticationBuilder.cs to check for these claims and throw the exception if found. The new exception class includes a property to store the invalid claim
Fixes #2968 (in this specific format)