Removed ConfigureAwait(false) from flaky tests #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
approved these changes
Sep 28, 2024
jennyf19
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Awesome. Thanks @JoshLozensky Please open an issue and attach to the PR for ease in tracking.
Closed
This was referenced Jul 28, 2025
Closed
This was referenced Aug 5, 2025
This was referenced Aug 15, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this guidance from XUnit, using
ConfigureAwait(false)in tests can lead to issues with synchronization and parallelization. In local testing removing ConfigureAwait seemed to work as I could repro flakiness locally in about 1-3 attempts but post-fix there was no observed flakiness locally after 14 attempts.That doesn't guarantee it fixes the build pipeline, but it looks promising so far. There is a risk of recurrence in the build pipeline even if this method is successful as I only edited tests that were observed as flaky in the last two weeks. Therefore, if a test still using ConfigureAwait(false) triggers flakiness but hasn't been failing itself, it would still be capable of breaking the build.