Fix for #2893 - do not attempt WorkloadIdentityCredential for MSI FIC (for Id.Web v2) #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
reviewed
Jun 13, 2024
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
I still don't understand.
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
changed the title
Member
Author
jmprieur
reviewed
Jun 25, 2024
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
why not cherry-pick the other commit? |
Member
Author
It is subtly different, because in 3.x we introduced a breaking change to the base classes. Have a look at e3a059f#diff-d515a839836ec1adc2d63d93fb6c38698476023fa4b444ca4f62424f8a3fa19aR56 |
jmprieur
approved these changes
Jun 27, 2024
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
We should run a release build ...
This was referenced Aug 1, 2025
This was referenced Aug 15, 2025
This was referenced Nov 3, 2025
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2813