-
Notifications
You must be signed in to change notification settings - Fork 241
Westinm/trimming #2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Westinm/trimming #2210
Changes from 9 commits
34b0c4b
cc78b82
fb5ce25
66c3e0c
a65c8c6
898be08
d24a544
144d99c
3afccd1
5674249
9eaa105
c0fbbed
c4bfd38
b165913
96ba4fb
561d4a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,12 @@ | |
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(TargetFramework)' == 'net6.0' or '$(TargetFramework)' == 'net7.0'"> | ||
| <EnableTrimAnalyzer>true</EnableTrimAnalyzer> | ||
| <PublishTrimmed>true</PublishTrimmed> | ||
westin-m marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <IsTrimmable>true</IsTrimmable> | ||
| </PropertyGroup> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we also want to try <EnableMicrosoftExtensionsConfigurationBinderSourceGenerator>true</EnableMicrosoftExtensionsConfigurationBinderSourceGenerator>if we use Microsoft.Extensions.Configuration.Binder NuGet package 8.*? and then remove the attributes which are due to the binding. Shall we do that when we enable .NET 8?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's do that as an increment.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I want to try this with .NET 8. |
||
|
|
||
| <PropertyGroup Condition="'$(TF_BUILD)' == 'true'"> | ||
| <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> | ||
| </PropertyGroup> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |
| using Microsoft.IdentityModel.Abstractions; | ||
| using Microsoft.IdentityModel.LoggingExtensions; | ||
| using Microsoft.IdentityModel.Logging; | ||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| namespace Microsoft.Identity.Web | ||
| { | ||
|
|
@@ -22,6 +23,9 @@ public class MicrosoftIdentityBaseAuthenticationBuilder | |
| /// </summary> | ||
| /// <param name="services">The services being configured.</param> | ||
| /// <param name="configurationSection">Optional configuration section.</param> | ||
| #if NET6_0_OR_GREATER | ||
| [RequiresUnreferencedCode("Calls Microsoft.Extensions.Configuration.ConfigurationBinder.Bind(IConfiguration, Object).")] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we do better in .NET 8? by enabling
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From what I read, probably. I do want to try this and test it when we add .NET 8. |
||
| #endif | ||
| protected MicrosoftIdentityBaseAuthenticationBuilder( | ||
| IServiceCollection services, | ||
| IConfigurationSection? configurationSection = null) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.