Change arc mi's detection algorithm #731
Conversation
rayluo
force-pushed
the
mi-arc-detection
branch
from
0b8db7d to
fe8f758
Compare
| if "IDENTITY_ENDPOINT" in os.environ and "IMDS_ENDPOINT" in os.environ: | ||
| return os.environ["IDENTITY_ENDPOINT"] |
There was a problem hiding this comment.
If detecting /var/opt/azcmagent/bin/himds and %ProgramFiles%\AzureConnectedMachineAgent\himds.exe is a reliable method, why bother checking IDENTITY_ENDPOINT and IMDS_ENDPOINT?
There was a problem hiding this comment.
Indeed, that is an open topic. @neha-bhargava asked the Arc team specifically on this but received no response.
The current implementation here aligns with the implementation in MSAL .Net. In any case, this subtlety shall be considered as an implementation detail, which might be adjusted in the future again.
There was a problem hiding this comment.
Agree with @rayluo. Added this in addition to env variable detection since env variables detection have been a success in case of windows. Might remove the env variable detection in future.
This PR will close #727