Skip to content

Use assertRaisesRegex instead of assertRaisesRegexp for Python 3.12 compatibility #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tirkarthi wants to merge 3 commits into from
Closed

Use assertRaisesRegex instead of assertRaisesRegexp for Python 3.12 compatibility #445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f934ecb
Use assertRaisesRegex instead of assertRaisesRegexp for Python 3.11 c…
tirkarthi Dec 22, 2021
c38af01
Fix Python 2.7 compatibility.
tirkarthi Dec 29, 2021
dc77ed8
Merge branch 'dev' into fix-assert
tirkarthi Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,16 @@ def test_auth_code_flow(self):
self.assertLoosely(result, lambda: self.assertIn('access_token', result))

def test_auth_code_flow_error_response(self):
with self.assertRaisesRegexp(ValueError, "state missing"):
if hasattr(self, "assertRaisesRegex"):
_assert = self.assertRaisesRegex
else:
_assert = self.assertRaisesRegexp

with _assert(ValueError, "state missing"):
self.client.obtain_token_by_auth_code_flow({}, {"code": "foo"})
with self.assertRaisesRegexp(ValueError, "state mismatch"):
with _assert(ValueError, "state mismatch"):
self.client.obtain_token_by_auth_code_flow({"state": "1"}, {"state": "2"})
with self.assertRaisesRegexp(ValueError, "scope"):
with _assert(ValueError, "scope"):
self.client.obtain_token_by_auth_code_flow(
{"state": "s", "scope": ["foo"]}, {"state": "s"}, scope=["bar"])
self.assertEqual(
Expand Down