Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting Regional Endpoint from env var #425

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Detecting Regional Endpoint from env var #425

merged 2 commits into from
Oct 28, 2021

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Oct 22, 2021

  • This PR adds back the behavior of detecting region based on env var REGION_NAME. Both short name (as eastus) or long name style (as West Us 2) are supported.

  • This time, we also make sure the entire regional endpoint behavior requires opt-in (as reiterated by this internal design), by either

    ConfidentialClientApplication(..., azure_region='westus', ...)

    or

    ConfidentialClientApplication(..., azure_region=ConfidentialClientApplication.ATTEMPT_REGION_DISCOVERY, ...)

    The default behavior does not utilize regional endpoint.

    ConfidentialClientApplication(..., azure_region=None, ...)

    In other words, the re-introduction of reading REGION_NAME env var would not regress The REGION_NAME env var should be prefixed with MSAL_ #382.

@rayluo rayluo merged commit 20eed4a into dev Oct 28, 2021
@rayluo rayluo deleted the region-env-var branch October 28, 2021 17:53
@rayluo rayluo mentioned this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant