Stop looking in localStorage for temporary cache

change/@azure-msal-browser-4e066b2f-6995-49dc-8d30-fb502ab69cf9.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Stop looking in localStorage for temporary cache [#8579](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/8579)",
+  "packageName": "@azure/msal-browser",
+  "email": "-g",
+  "dependentChangeType": "patch"
+}

lib/msal-browser/src/cache/BrowserCacheManager.ts

@@ -1901,30 +1901,12 @@ export class BrowserCacheManager extends CacheManager {
         correlationId: string,
         generateKey?: boolean
     ): string | null {
+        this.logger.trace(
+            "BrowserCacheManager.getTemporaryCache called",
+            correlationId
+        );
         const key = generateKey ? this.generateCacheKey(cacheKey) : cacheKey;
-        const value = this.temporaryCacheStorage.getItem(key);
-        if (!value) {
-            // If temp cache item not found in session/memory, check local storage for items set by old versions
-            if (
-                this.cacheConfig.cacheLocation ===
-                BrowserCacheLocation.LocalStorage
-            ) {
-                const item = this.browserStorage.getItem(key);
-                if (item) {
-                    this.logger.trace(
-                        "BrowserCacheManager.getTemporaryCache: Temporary cache item found in local storage",
-                        correlationId
-                    );
-                    return item;
-                }
-            }
-            this.logger.trace(
-                "BrowserCacheManager.getTemporaryCache: No cache item found in local storage",
-                correlationId
-            );
-            return null;
-        }
-        return value;
+        return this.temporaryCacheStorage.getItem(key);
     }
 
     /**

lib/msal-browser/test/cache/BrowserCacheManager.spec.ts

@@ -1875,29 +1875,6 @@ describe("BrowserCacheManager tests", () => {
             expect(window.sessionStorage.getItem(msalCacheKey2)).toBe(cacheVal);
         });
 
-        it("getTemporaryCache falls back to local storage if not found in session/memory storage", () => {
-            const testTempItemKey = "test-temp-item-key";
-            const testTempItemValue = "test-temp-item-value";
-            window.localStorage.setItem(testTempItemKey, testTempItemValue);
-            browserLocalStorage = new BrowserCacheManager(
-                TEST_CONFIG.MSAL_CLIENT_ID,
-                {
-                    ...cacheConfig,
-                    cacheLocation: BrowserCacheLocation.LocalStorage,
-                },
-                browserCrypto,
-                logger,
-                new StubPerformanceClient(),
-                new EventHandler()
-            );
-            expect(
-                browserLocalStorage.getTemporaryCache(
-                    testTempItemKey,
-                    TEST_CONFIG.CORRELATION_ID
-                )
-            ).toBe(testTempItemValue);
-        });
-
         it("setItem", () => {
             window.sessionStorage.setItem(msalCacheKey, cacheVal);
             window.localStorage.setItem(msalCacheKey2, cacheVal);