Remove usage of Lab API for integration test config#8289
Closed
Avery-Dunn wants to merge 18 commits intodevfrom
Closed
Remove usage of Lab API for integration test config#8289Avery-Dunn wants to merge 18 commits intodevfrom
Avery-Dunn wants to merge 18 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates integration tests from the deprecated Lab API (msidlab.com/api/) to a Key Vault-based configuration system, aligning with changes made in other MSAL libraries (Java, .NET, Go, Python).
Changes:
- Introduces new
labUtilspackage for Key Vault-based test configuration retrieval - Refactors
client-credentials-aad.spec.tsto use Key Vault instead of Lab API - Adds new
obo-aad-kv.spec.tsas example OBO tests using Key Vault (marked for potential removal) - Minor formatting fix to
obo-aad.spec.ts(trailing comma)
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/labUtils/* | New utility package for retrieving test config from Azure Key Vault instead of Lab API |
| samples/msal-node-samples/client-credentials/test/client-credentials-aad.spec.ts | Updated to use Key Vault-based config via labUtils |
| samples/msal-node-samples/on-behalf-of/test/obo-aad-kv.spec.ts | New example test demonstrating OBO with Key Vault config |
| samples/msal-node-samples/on-behalf-of/test/obo-aad.spec.ts | Minor formatting fix (trailing comma) |
| samples/msal-node-samples/*/package.json | Added lab-utils dependency |
| samples/labUtils/package.json | Package definition for new labUtils utility |
| package-lock.json | Dependency updates for lab-utils package |
Contributor
Author
|
Closing in favor of a branch based on msal-v5 instead of dev: #8319 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a draft PR that only changes a few tests, in order to help with discussions and confirm this is the right direction for the changes.
This PR makes similar changes to what is being done in other MSALs:
AzureAD/microsoft-authentication-library-for-java#1002
AzureAD/microsoft-authentication-library-for-dotnet#5631
AzureAD/microsoft-authentication-library-for-go#593
AzureAD/microsoft-authentication-library-for-python#870
Historically, integration tests in MSAL and MISE retrieved user/app/tenant/etc. info from our API at "https://msidlab.com/api/"
That API is being deprecated in favor of a key vault-based system: instead of dynamic config based on query parameters, we have a simpler set of config stored as key vault secrets.
This PR refactors the integration tests to retrieve the config they need from those key vaults instead of the API:
labUtils: A new group of helper classes/functions/etc. which retrieves and parses test config from key vaultsclient-credentials-aad.spec.ts: Tests were adjusted to use the new helpers inlabUtilsobo-aad-kv.spec.ts: New tests that match the OBO style of other MSALS, particularly MSAL .NET