Skip to content

Revert WithTenantID("adfs") regression#529

Merged
chlowell merged 1 commit intomainfrom
chlowell/adfs-tenant
Nov 6, 2024
Merged

Revert WithTenantID("adfs") regression#529
chlowell merged 1 commit intomainfrom
chlowell/adfs-tenant

Conversation

@chlowell
Copy link
Contributor

@chlowell chlowell commented Nov 6, 2024

In v1.3.0, calls like this against an ADFS authority return an error "ADFS authority doesn't support tenants":

client.AcquireTokenSilent(ctx, scopes, confidential.WithTenantID("adfs"))

This happens because #482 made the tenant of an ADFS authority "". In prior versions, that tenant was "adfs", making WithTenantID("adfs") a no-op.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

@chlowell chlowell merged commit 9bf4a83 into main Nov 6, 2024
@chlowell chlowell deleted the chlowell/adfs-tenant branch November 6, 2024 20:08
4gust pushed a commit that referenced this pull request Nov 8, 2024
4gust pushed a commit that referenced this pull request Nov 11, 2024
4gust pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants