Refactored and fixed device code sample by hchittanuru3 · Pull Request #1 · AzureAD/microsoft-authentication-library-for-go

hchittanuru3 · 2020-05-29T18:19:10Z

Refactored imports to make it work locally
Added a device code sample in src/examples/devicecodeflow/main.go
Fixed DeviceCodeRequest and Token Response to handle authorization_pending and slow_down errors

src/examples/msalconsole/main.go

henrik-me · 2020-05-29T22:37:07Z

consider sharing code between the samples and refactor usernamepwd flow to match what you added for device code... or build one sample that can do both and ask for the user for a key to pick auth method

src/internal/requests/WebRequestManager.go

henrik-me · 2020-05-29T22:41:59Z

Do you mind adding a bit more to the readme file on how to run the samples?

henrik-me

hchittanuru3 · 2020-06-01T17:05:04Z

consider sharing code between the samples and refactor usernamepwd flow to match what you added for device code... or build one sample that can do both and ask for the user for a key to pick auth method

Added in this commit.

hchittanuru3 · 2020-06-01T17:05:35Z

Do you mind adding a bit more to the readme file on how to run the samples?

Added this in this commit.

sangonzal

Overall looks great. Thank for cleaning up.

Also one more thing that we need to have a full device code implementation:

A mechanism so that callers can cancel polling. While the polling is happening, the caller should be able to set cancel to true and that would cause the MSAL to break out of the polling loop.

src/internal/requests/DeviceCodeRequest.go

…de back to user

hchittanuru3 · 2020-06-03T16:57:42Z

In this new commit, the following changes have been made:

PublicClientApplication now has a AcquireDeviceCode function, so the device code result values can be returned to the user, instead of logged to the terminal.
The flow has slightly changes, so users need to call AcquireDeviceCode and use the DeviceCodeRequest value as a parameter for AcquireTokenByDeviceCode.
The DeviceCodeRequest now stores a DeviceCodeResult as well as a cancel flag.
The DeviceCodeSample has both examples of device code flow with and without cancellation.

sangonzal

Great progress. A couple of questions.

sangonzal · 2020-06-05T23:19:06Z

src/AcquireTokenDeviceCodeParameters.go

 	authParams.SetAuthorizationType(msalbase.AuthorizationTypeDeviceCode)
 }
+
+func (p *AcquireTokenDeviceCodeParameters) InternalCallback(dcr *msalbase.DeviceCodeResult) {


Do we need an internal callback? Can we just call deviceCodeCallback directly?

This is to cast it to the interface IDeviceCodeResult. The internal library returns a DeviceCodeResult, and to make it accessible to the user, we utilize IDeviceCodeResult.

Can we use the interface in the method signatures internally as well? We should try to use the interface wherever possible.

The interface is not accessible to the internal package. The DeviceCodeRequest uses this callback and passes in a DeviceCodeResult, which this InternalCallback casts to the interface type IDeviceCodeResult.

Can we make the interface accessible to the internal package?

src/PublicClientApplication.go

src/examples/DeviceCodeFlowSample.go

src/internal/msalbase/DeviceCodeResult.go

src/internal/requests/DeviceCodeRequest.go

src/internal/msalbase/DeviceCodeResult.go

src/PublicClientApplication.go

src/internal/requests/DeviceCodeRequest.go

src/internal/requests/IWebRequestManager.go

sangonzal · 2020-06-09T00:57:29Z

src/internal/requests/DeviceCodeRequest.go

+	}

+	req.authParameters.SetAuthorityEndpoints(endpoints)
 	deviceCodeResult, err := req.webRequestManager.GetDeviceCodeResult(req.authParameters)


Can we update GetDeviceCodeResult to return IDeviceCodeResult? In line 50, req.deviceCodeCallback() can then be updated to be the callback set by the developer, instead of the internal callback?

sangonzal · 2020-06-09T00:58:09Z

src/AcquireTokenDeviceCodeParameters.go

 	authParams.SetAuthorizationType(msalbase.AuthorizationTypeDeviceCode)
 }
+
+func (p *AcquireTokenDeviceCodeParameters) InternalCallback(dcr *msalbase.DeviceCodeResult) {


Can we make the interface accessible to the internal package?

…soft-authentication-library-for-go into device-code-sample

sangonzal

Looks good to me.

…t readability Previously, the test results were printed as #0 #1 #2, which made it hard to navigate the failed test cases. Now, the test cases are annotated by their respective names. The names also make it more clear what is being unit-tested.

Refactored and fixed device code sample

a29f377

hchittanuru3 requested review from henrik-me and sangonzal May 29, 2020 18:19

henrik-me requested a review from SomkaPe May 29, 2020 22:32

henrik-me reviewed May 29, 2020

View reviewed changes

src/examples/msalconsole/main.go Outdated Show resolved Hide resolved

henrik-me reviewed May 29, 2020

View reviewed changes

src/internal/requests/WebRequestManager.go Show resolved Hide resolved

henrik-me approved these changes May 29, 2020

View reviewed changes

sangonzal suggested changes Jun 1, 2020

View reviewed changes

src/internal/requests/DeviceCodeRequest.go Outdated Show resolved Hide resolved

Hemanth Chittanuru added 3 commits June 1, 2020 17:59

Addressed concerns in PR

739e2f0

Moved variables to config and added readMe

b7db837

Updated Device Code Flow to handle cancellation and returns device co…

b589d7b

…de back to user

Hemanth Chittanuru added 4 commits June 4, 2020 17:35

New Device Code Flow

3b0219b

Updating Requests

4b9b5a6

Added device code callback

c57ccfc

Update sample readme

071d861

sangonzal reviewed Jun 5, 2020

View reviewed changes

Addressing comments in PR

df99c12

sangonzal reviewed Jun 8, 2020

View reviewed changes

src/internal/requests/DeviceCodeRequest.go Show resolved Hide resolved

src/internal/requests/IWebRequestManager.go Outdated Show resolved Hide resolved

Update IWebRequestManager.go

b683bc2

sangonzal reviewed Jun 9, 2020

View reviewed changes

hchittanuru3 linked an issue Jun 9, 2020 that may be closed by this pull request

Get Device Code Flow to work (Public Client App) #3

Closed

Hemanth Chittanuru added 3 commits June 9, 2020 17:48

Added contexts to signal canceling

89a47b9

Refactored

12ebd17

Merge branch 'device-code-sample' of https://github.com/AzureAD/micro…

5af4868

…soft-authentication-library-for-go into device-code-sample

hchittanuru3 requested a review from sangonzal June 10, 2020 18:56

sangonzal approved these changes Jun 15, 2020

View reviewed changes

hchittanuru3 merged commit ee1f38a into dev Jun 15, 2020

hchittanuru3 deleted the device-code-sample branch June 15, 2020 17:17

Conversation

hchittanuru3 commented May 29, 2020

Uh oh!

Uh oh!

henrik-me commented May 29, 2020

Uh oh!

Uh oh!

henrik-me commented May 29, 2020

Uh oh!

henrik-me left a comment

Choose a reason for hiding this comment

Uh oh!

hchittanuru3 commented Jun 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hchittanuru3 commented Jun 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sangonzal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hchittanuru3 commented Jun 3, 2020

Uh oh!

sangonzal left a comment

Choose a reason for hiding this comment

Uh oh!

sangonzal Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

hchittanuru3 Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

sangonzal Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

hchittanuru3 Jun 9, 2020

Choose a reason for hiding this comment

Uh oh!

sangonzal Jun 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sangonzal Jun 9, 2020

Choose a reason for hiding this comment

Uh oh!

sangonzal Jun 9, 2020

Choose a reason for hiding this comment

Uh oh!

sangonzal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hchittanuru3 commented Jun 1, 2020 •

edited

Loading

hchittanuru3 commented Jun 1, 2020 •

edited

Loading