-
Notifications
You must be signed in to change notification settings - Fork 412
mTLS PoP: add SNI / S2S-FIC test coverage + docs #6100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+399
−352
Merged
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8da3c10
Support SNI cert over mTLS PoP and S2S FIC; fix stale region-required…
Robbie-Microsoft 82cedcb
Consolidate two-leg S2S FIC mTLS PoP E2E coverage and fix FMI leg cli…
Robbie-Microsoft 0101442
Merge remote-tracking branch 'origin/main' into rginsburg/sni-mtls-po…
Robbie-Microsoft c5c0046
docs: clarify global mTLS host is cloud-specific; fix region example
Robbie-Microsoft 043e1ef
Review nits: drop public-only host from region messages; reuse resour…
Robbie-Microsoft fd0077b
Address review: revert guardrail comment; simplify dead region-error …
Robbie-Microsoft e1f5aa9
docs/test: correct BindingCertificate wording; cloud-specific global …
Robbie-Microsoft 7aaeca8
Rescope PR to tests + docs: move region-message fix to #6127
Robbie-Microsoft c923621
Merge remote-tracking branch 'origin/main' into rginsburg/sni-mtls-po…
Robbie-Microsoft 9ec4cfa
Clarify allow-listed resource comment: constant is used by FIC tests;…
Robbie-Microsoft 451c990
Call Microsoft Graph over mTLS in the SNI/FIC mTLS PoP E2E tests
Robbie-Microsoft 7cbf4fe
Merge remote-tracking branch 'origin/main' into rginsburg/sni-mtls-po…
Robbie-Microsoft 44169fb
Remove misdesigned FMI-audience mTLS PoP E2E test
Robbie-Microsoft 4565fb1
Assert SNI/carried cert is presented on the mTLS handshake in unit tests
Robbie-Microsoft 6be21b5
Fail (not skip) when the allow-listed app is rejected calling Graph o…
Robbie-Microsoft dbe7f5c
Truncate resource body in test log messages; fix region-error doc wor…
Robbie-Microsoft 573e332
Tidy SNI/S2S-FIC mTLS PoP tests and docs per review
Robbie-Microsoft 6f4f8af
Make Graph-over-mTLS resource check strictly 200-or-fail
Robbie-Microsoft 621a288
Trim redundant comments in mTLS PoP E2E tests
Robbie-Microsoft 9e00972
Collapse mTLS PoP E2E tests to 4 canonical credential x output cases
Robbie-Microsoft ba2e43b
Merge origin/main into rginsburg/sni-mtls-pop-fic
Robbie-Microsoft 225599e
Fold mTLS PoP resource-call assert into an explicit 200 check
Robbie-Microsoft cb8eb69
Merge remote-tracking branch 'origin/main' into rginsburg/sni-mtls-po…
Robbie-Microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.