Skip to content

Promote MsalServiceException.SubError to public #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neha-bhargava merged 5 commits into from
Jun 16, 2026
+39 −30
Merged

Promote MsalServiceException.SubError to public #6063

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b157a83
Make MsalServiceException.SubError public
neha-bhargava Jun 11, 2026
4a7100d
Review-pass fixes: MsalServiceException.SubError setter stays interna…
neha-bhargava Jun 15, 2026
620dc9d
Merge branch 'main' into nebharg/metadata-surface-poc
neha-bhargava Jun 15, 2026
d6d983b
Rename MsalServiceException.SubError to SubErrorForLogging
neha-bhargava Jun 15, 2026
d9f38b5
Merge branch 'main' into nebharg/metadata-surface-poc
neha-bhargava Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/client/Microsoft.Identity.Client/MsalServiceException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,12 @@ public HttpResponseHeaders Headers

#endregion

/// <remarks>
/// The suberror should not be exposed for public consumption yet, as STS needs to do some work first.
/// </remarks>
internal string SubError { get; set; }
/// <summary>
/// Sub-error returned by the token service refining <see cref="MsalException.ErrorCode"/>
/// (for example <c>consent_required</c>, <c>bad_token</c>, <c>protection_policy_required</c>).
/// Values are emitted by the service and may change without notice.
Comment thread
neha-bhargava marked this conversation as resolved.
Outdated
/// </summary>
public string SubError { get; internal set; }
Comment thread
neha-bhargava marked this conversation as resolved.
Outdated

/// <summary>
/// A list of STS-specific error codes that can help in diagnostics.
Expand Down
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
1 change: 1 addition & 0 deletions src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Microsoft.Identity.Client.MsalServiceException.SubError.get -> string
Microsoft.Identity.Client.AzureCloudInstance.GovFr = 5 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovDe = 6 -> Microsoft.Identity.Client.AzureCloudInstance
Microsoft.Identity.Client.AzureCloudInstance.GovSg = 7 -> Microsoft.Identity.Client.AzureCloudInstance
Loading