-
Notifications
You must be signed in to change notification settings - Fork 404
Add OID-based user identification to UserFIC (user_fic) flow #6050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9ca9b04
Add OID-based user identification to UserFIC (user_fic) flow
Avery-Dunn c56acf0
Merge remote-tracking branch 'origin/main' into avdunn/fic-oid-support
Avery-Dunn 43331d0
Adjust username/oid logging
Avery-Dunn 162ff1b
Update FIC logging
Avery-Dunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...ty.Client/ApiConfig/Parameters/AcquireTokenByUserFederatedIdentityCredentialParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,47 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System; | ||
| using System.Text; | ||
| using Microsoft.Identity.Client.Core; | ||
|
|
||
| namespace Microsoft.Identity.Client.ApiConfig.Parameters | ||
| { | ||
| internal class AcquireTokenByUserFederatedIdentityCredentialParameters : IAcquireTokenParameters | ||
| { | ||
| public string Username { get; set; } | ||
| public Guid? UserObjectId { get; set; } | ||
| public string Assertion { get; set; } | ||
| public bool? SendX5C { get; set; } | ||
| public bool ForceRefresh { get; set; } | ||
|
|
||
| /// <inheritdoc/> | ||
| public void LogParameters(ILoggerAdapter logger) | ||
| { | ||
| if (logger.IsLoggingEnabled(LogLevel.Info)) | ||
| { | ||
| // PII-enabled message: includes actual Username and UserObjectId values | ||
| var builder = new StringBuilder(); | ||
| builder.AppendLine("=== AcquireTokenByUserFederatedIdentityCredentialParameters ==="); | ||
| builder.AppendLine("SendX5C: " + SendX5C); | ||
| builder.AppendLine("ForceRefresh: " + ForceRefresh); | ||
| builder.AppendLine("Username: " + Username); | ||
| builder.AppendLine("UserObjectId: " + UserObjectId); | ||
| builder.AppendLine("Assertion set: " + !string.IsNullOrEmpty(Assertion)); | ||
|
|
||
| string messageWithPii = builder.ToString(); | ||
|
|
||
| // Non-PII message: redacts Username and UserObjectId to booleans | ||
| builder = new StringBuilder(); | ||
| builder.AppendLine("=== AcquireTokenByUserFederatedIdentityCredentialParameters ==="); | ||
| builder.AppendLine("SendX5C: " + SendX5C); | ||
| builder.AppendLine("ForceRefresh: " + ForceRefresh); | ||
| builder.AppendLine("Username set: " + !string.IsNullOrEmpty(Username)); | ||
| builder.AppendLine("UserObjectId set: " + UserObjectId.HasValue); | ||
| builder.AppendLine("Assertion set: " + !string.IsNullOrEmpty(Assertion)); | ||
|
|
||
| logger.InfoPii(messageWithPii, builder.ToString()); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.