Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates desktop OS detection in MSAL.NET to recognize Mac Catalyst as “macOS” for desktop-only behaviors (notably default-system-browser launching), addressing PlatformNotSupportedException failures seen in Mac Catalyst interactive flows on newer .NET runtimes.
Changes:
- Extend
DesktopOsHelper.IsMac()to returntruefor Mac Catalyst (inNET8_0_OR_GREATERbuilds).
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
Mar 24, 2026
fengga
reviewed
Mar 24, 2026
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs
Show resolved
Hide resolved
fengga
approved these changes
Mar 24, 2026
ashok672
changed the title
bgavrilMS
approved these changes
Mar 30, 2026
This was referenced Mar 30, 2026
Open
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5590
Update desktop OS detection to treat Mac Catalyst as macOS by combining OperatingSystem.IsMacOS() with OperatingSystem.IsMacCatalystVersionAtLeast(13, 1).
This resolves PlatformNotSupportedException in Mac Catalyst system-browser interactive authentication flows.