Conversation
There was a problem hiding this comment.
Pull request overview
Updates the centrally-managed Microsoft.Identity.Client.NativeInterop package version to pick up fixes (notably a macOS broker bug) across the repo’s MSAL/Broker builds.
Changes:
- Bump
MSALRuntimeNativeInteropVersionfrom0.19.4to0.20.3in central package management.
45224ff to
4111682
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Microsoft.Identity.Client.NativeInterop dependency to 0.20.3 to pick up the macOS broker fix referenced in the PR description.
Changes:
- Bump NativeInterop package version to 0.20.3 in central package props.
- Align macOS dev app project references to NativeInterop 0.20.3.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/devapps/MacMauiAppWithBroker/MacMauiAppWithBroker.csproj | Updates NativeInterop PackageReference to 0.20.3 for the macOS MAUI broker dev app. |
| tests/devapps/MacConsoleAppWithBroker/MacConsoleAppWithBroker.csproj | Updates NativeInterop PackageReference to 0.20.3 for the macOS console broker dev app. |
| Directory.Packages.props | Updates the centrally managed NativeInterop version property to 0.20.3. |
You can also share your feedback on Copilot code review. Take the survey.
|
We will also need to mention that on Ubuntu 22, libwebkit2gtk4.1 would be the dependency - pr here: MicrosoftDocs/microsoft-authentication-library-dotnet#744 |
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Identity.Client.NativeInterop dependency to 0.20.3 across the repo (and Mac devapps) to pick up a macOS broker fix, and adjusts a Linux dependency install script.
Changes:
- Bump centralized NativeInterop version to
0.20.3viaDirectory.Packages.props. - Update macOS devapps to reference NativeInterop
0.20.3. - Change Linux apt dependency from
libwebkit2gtk-4.0-devtolibwebkit2gtk-4.1-dev.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/devapps/MacMauiAppWithBroker/MacMauiAppWithBroker.csproj | Updates macOS MAUI broker devapp NativeInterop package version to 0.20.3. |
| tests/devapps/MacConsoleAppWithBroker/MacConsoleAppWithBroker.csproj | Updates macOS console broker devapp NativeInterop package version to 0.20.3. |
| build/linux-install-deps.sh | Updates an apt-installed WebKitGTK dev package version. |
| Directory.Packages.props | Central bump of MSALRuntimeNativeInteropVersion to 0.20.3 for repo-wide consumption. |
Fixes #
NativeInterop 0.20.3 fixes a macOS broker bug, and the flow was verified by several different sources.
Changes proposed in this request
Testing
Performance impact
Documentation