Fix fallback where OpenTelemetry instrumentation is not available#5710
Closed
fowl2 wants to merge 1 commit intoAzureAD:mainfrom
Closed
Fix fallback where OpenTelemetry instrumentation is not available#5710fowl2 wants to merge 1 commit intoAzureAD:mainfrom
fowl2 wants to merge 1 commit intoAzureAD:mainfrom
Conversation
bgavrilMS
approved these changes
Feb 5, 2026
Member
|
Thanks for the contribution @fowl2 |
neha-bhargava
approved these changes
Feb 5, 2026
This was referenced Feb 5, 2026
Copilot AI
added a commit
that referenced
this pull request
Feb 5, 2026
…dling This integrates the changes from external PR #5710 by @fowl2 which expands exception handling for OpenTelemetry initialization to catch TypeLoadException and TypeInitializationException in addition to FileNotFoundException. Reference: #5710 Co-authored-by: neha-bhargava <61847233+neha-bhargava@users.noreply.github.com>
1 task
neha-bhargava
added a commit
that referenced
this pull request
Feb 6, 2026
…mpatibility (#5720) * Initial plan * Fix fallback where OpenTelemetry instrumentation is not available Follow up to #4487 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: James May <fowl2@users.noreply.github.com> Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
Contributor
|
Merged. Thanks @fowl2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing OTel, additionally catch
TypeLoadExceptionandTypeInitializationExceptionwhich wrap existing catch ofFileNotFoundExceptionwhen only older version ofSystem.Diagnostics.DiagnosticSourceis loaded, such as on some Azure Functions versions.Follow up to #4487
edit: I can see this was actually already considered but it was decided to only include if the other exceptions were observed. I'm observing
TypeLoadException.