Skip to content

Remove experimental flag requirement from IAuthenticationOperation #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gladjohn merged 4 commits into from
Feb 3, 2026
+0 −6
Merged

Remove experimental flag requirement from IAuthenticationOperation #5699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7462b5e
Initial plan
Copilot Feb 2, 2026
966a62a
Remove experimental flag from IAuthenticationOperation and WithAuthen…
Copilot Feb 2, 2026
ae2ab53
Update AuthenticationOperationTests to remove experimental flag requi…
Copilot Feb 2, 2026
a59be20
Merge branch 'main' into copilot/remove-experimental-flag-authentication
bgavrilMS Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/client/Microsoft.Identity.Client/ApiConfig/AbstractAcquireTokenParameterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ public T WithB2CAuthority(string authorityUri)

internal /* for testing */ T WithAuthenticationOperation(IAuthenticationOperation authOperation)
{
ValidateUseOfExperimentalFeature();
CommonParameters.AuthenticationOperation = authOperation ?? throw new ArgumentNullException(nameof(authOperation));
return this as T;
}
Expand Down
2 changes: 0 additions & 2 deletions ...y.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ public static AbstractAcquireTokenParameterBuilder<T> WithAdditionalCacheParamet
return builder;
}

builder.ValidateUseOfExperimentalFeature();

//Check if the cache parameters are already initialized, if so, add to the existing list
if (builder.CommonParameters.AdditionalCacheParameters != null)
{
Expand Down
3 changes: 0 additions & 3 deletions tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public async Task Should_UseCustomRequestHeaders_And_StoreAdditionalParameters()
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
.WithClientSecret(TestConstants.ClientSecret)
.WithHttpManager(httpManager)
.WithExperimentalFeatures(true)
.BuildConcrete();

HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));
Expand Down Expand Up @@ -78,7 +77,6 @@ public async Task Should_UseCustomRequestHeaders_And_StoreAdditionalParametersWi
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
.WithClientSecret(TestConstants.ClientSecret)
.WithHttpManager(httpManager)
.WithExperimentalFeatures(true)
.BuildConcrete();

HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));
Expand Down Expand Up @@ -158,7 +156,6 @@ public async Task Should_UseEmptyExtension_And_Parameters()
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
.WithClientSecret(TestConstants.ClientSecret)
.WithHttpManager(httpManager)
.WithExperimentalFeatures(true)
.BuildConcrete();

HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));
Expand Down