-
Notifications
You must be signed in to change notification settings - Fork 395
Add mTLS PoP validation for unsupported and non-login hosts #5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0dafcf4
Initial plan
Copilot 8d362e3
Add mTLS PoP blocking for unsupported sovereign hosts
Copilot 154ecd2
Address code review feedback - improve error messages and host compar…
Copilot 530e82a
Update public API files for new MsalError constant
Copilot b20d273
Refactor mTLS validation: use dictionary and move to fail-fast position
Copilot 66b129a
Make error messages public and add validation for non-login hosts
Copilot e015649
Revert error message constants from public to internal
Copilot 2ec5f19
Change error message constants from internal to public for consistency
Copilot 3ec71c7
Merge branch 'main' into copilot/add-mtls-error-code-support
gladjohn f8cd8d1
Fix static field naming to follow s_camelCase convention
Copilot 57109cf
Move Dictionary to using statement instead of fully qualified name
Copilot 00c708f
Remove accidentally committed .mono build artifacts and update .gitig…
Copilot d75fb65
Delete mtls_pop_test_results.txt
gladjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| Build started 01/29/2026 14:27:45. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this file needed? Remove? |
||
| 1>Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/tests/Microsoft.Identity.Test.Unit/Microsoft.Identity.Test.Unit.csproj" on node 1 (Restore target(s)). | ||
| 1>_GetAllRestoreProjectPathItems: | ||
| Determining projects to restore... | ||
| 1>Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/tests/Microsoft.Identity.Test.Unit/Microsoft.Identity.Test.Unit.csproj" (1) is building "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (2:8) on node 1 (_GenerateProjectRestoreGraph target(s)). | ||
| 2:8>Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (2:8) is building "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (2:12) on node 1 (_GenerateProjectRestoreGraphPerFramework target(s)). | ||
| 2>/usr/share/dotnet/sdk/8.0.417/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1100: To build a project targeting Windows on this operating system, set the EnableWindowsTargeting property to true. [/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj::TargetFramework=netcoreapp3.1] | ||
| 2>Done Building Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (_GenerateProjectRestoreGraphPerFramework target(s)) -- FAILED. | ||
| 2>Done Building Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (_GenerateProjectRestoreGraph target(s)) -- FAILED. | ||
| 1>Done Building Project "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/tests/Microsoft.Identity.Test.Unit/Microsoft.Identity.Test.Unit.csproj" (Restore target(s)) -- FAILED. | ||
|
|
||
| Build FAILED. | ||
|
|
||
| "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/tests/Microsoft.Identity.Test.Unit/Microsoft.Identity.Test.Unit.csproj" (Restore target) (1) -> | ||
| "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (_GenerateProjectRestoreGraph target) (2:8) -> | ||
| "/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj" (_GenerateProjectRestoreGraphPerFramework target) (2:12) -> | ||
| (ProcessFrameworkReferences target) -> | ||
| /usr/share/dotnet/sdk/8.0.417/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1100: To build a project targeting Windows on this operating system, set the EnableWindowsTargeting property to true. [/home/runner/work/microsoft-authentication-library-for-dotnet/microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client.Desktop/Microsoft.Identity.Client.Desktop.csproj::TargetFramework=netcoreapp3.1] | ||
|
|
||
| 0 Warning(s) | ||
| 1 Error(s) | ||
|
|
||
| Time Elapsed 00:00:01.61 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.