Skip to content

Add Credential Guard attestation native DLL handling with centralized versioning#5674

Merged
gladjohn merged 11 commits intomainfrom
copilot/update-key-attestation-dll-handling
Feb 24, 2026
Merged

Add Credential Guard attestation native DLL handling with centralized versioning#5674
gladjohn merged 11 commits intomainfrom
copilot/update-key-attestation-dll-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 26, 2026

This pull request introduces support for the Microsoft.Azure.Security.KeyGuardAttestation package and improves the build pipeline to handle and verify the presence of new managed identity application DLLs. The changes ensure that the new dependency is included in both the project and the build process, and that automated checks are in place to confirm required files are present after builds.

Dependency management:

  • Added Microsoft.Azure.Security.KeyGuardAttestation version 1.1.5 to the solution's package management in Directory.Packages.props.
  • Added a PackageReference for Microsoft.Azure.Security.KeyGuardAttestation to the Microsoft.Identity.Client.KeyAttestation project file.

Build pipeline enhancements:

  • Updated the build pipeline (template-build-and-prep-automation.yaml) to copy Managed Identity DevApp DLLs from ManagedIdentityAppVM to the build directory.
  • Added a step in the build pipeline to check for the existence of AttestationClientLib.dll in the managed identity app's runtime output, and report errors if missing.
  • Cleaned up the file check completion messaging in the build pipeline script.

Co-authored-by: gladjohn <90415114+gladjohn@users.noreply.github.com>
Copilot AI changed the title [WIP] Update key attestation project to manage Credential Guard DLLs Add Credential Guard attestation native DLL handling with centralized versioning Jan 26, 2026
Copilot AI requested a review from gladjohn January 26, 2026 21:25
@gladjohn gladjohn marked this pull request as ready for review January 26, 2026 22:03
@gladjohn gladjohn requested a review from a team as a code owner January 26, 2026 22:03
@bgavrilMS bgavrilMS requested a review from MZOLN January 27, 2026 19:53
@gladjohn gladjohn requested a review from bgavrilMS February 5, 2026 18:03
@gladjohn
Copy link
Copy Markdown
Contributor

@MZOLN @bgavrilMS can I please get a review on this one?

Copy link
Copy Markdown
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native DLL placing

Copy link
Copy Markdown
Contributor

@MZOLN MZOLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

Added a target to verify the presence of AttestationClientLib.dll in the output directory during the build process.
@gladjohn gladjohn merged commit 3598350 into main Feb 24, 2026
11 checks passed
This was referenced Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants