-
Notifications
You must be signed in to change notification settings - Fork 378
[Draft] Labmigration #5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RyAuld
wants to merge
42
commits into
main
Choose a base branch
from
labmigration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft] Labmigration #5558
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
c48ee29
Complete Key Vault migration with ObjectId validation
RyAuld 12e0e44
Complete Key Vault migration and update OnBehalfOf tests
RyAuld 855e19b
Enhance lab infrastructure with debug logging and ADFS 2022 support
RyAuld ea1a6f7
Update UsernamePasswordIntegrationTests.NetFwk.cs with additional impβ¦
RyAuld 5417662
Align UsernamePasswordIntegrationTests.NetFwk.cs with main branch - cβ¦
RyAuld 78659e9
Restore complete LabMigration version of UsernamePasswordIntegrationTβ¦
RyAuld 37e1665
Update LabUserHelper calls to use LabMigration enhanced methods whileβ¦
RyAuld 86e591d
Fix GetHybridSpaAccontAsync to use Key Vault approach instead of old β¦
RyAuld 67e51ac
Complete migration to new lab infrastructure
RyAuld 30ee25b
Fix failing tests in labmigration branch
RyAuld 4714ab9
Fix CacheCompat test compilation errors
RyAuld 613d4dc
Trigger pipeline rebuild with latest changes
RyAuld 352b44d
Migrate integration tests from MSIDLAB4 to id4slab1 tenant
RyAuld cfbd534
Complete MSAL.NET OBO integration test migration to ID4SLAB1 tenant
RyAuld 61cc635
Migrate ADFS tests from fs.msidlab8.com to fs.id4slab1.com
RyAuld dc39585
Merge branch 'main' into labmigration
RyAuld ac6cd53
Add missing CreateAadTestTokenResponseWithMsalUserDefault method
RyAuld 00cf259
Merge branch 'labmigration' of https://github.com/AzureAD/microsoft-aβ¦
RyAuld 10309b3
Fix tenant routing issue by using multi-tenant app for integration tests
RyAuld 10f838b
Fix HybridSPA test to use multi-tenant app and clean up whitespace
RyAuld 348813d
Clean up trailing whitespace in commented code
RyAuld b1eda23
Merge remote-tracking branch 'origin/main' into labmigration
RyAuld 211f861
Fix device code flow tests to use tenant-specific authority
RyAuld 8b63d36
Add GetDefaultUserWithMultiTenantAppAsync method and update device coβ¦
RyAuld 066af43
Fix AADSTS700016 errors by migrating to multi-tenant app configuration
RyAuld 22ebda2
Fix additional tests using default user instead of multi-tenant app
RyAuld 85ad81a
Fix more tests using /common endpoint with single-tenant app
RyAuld 7a92a52
Final migration updates - OBO tests and interactive flow fixes
RyAuld ae9ba1a
Fix interactive tests to use correct app configuration
RyAuld b1fbc93
Remove Selenium.WebDriver.ChromeDriver package reference to match maiβ¦
RyAuld bd86c1a
Merge branch 'main' into labmigration
RyAuld 6c04b9b
Optimize OBO test initialization - remove redundant GetDefaultUserWitβ¦
RyAuld fc48e04
Address PR feedback for GetKVLabData method - improve type safety andβ¦
RyAuld f3036da
Optimize JSON parsing in GetKVLabDataAsync - eliminate duplicate parsing
RyAuld bcaa90a
Clean up OnBehalfOfTests.cs - Remove outdated migration comment
RyAuld d62ad71
Refactor ConfidentialAppSettings for Single Responsibility Principle
RyAuld fab8f37
Fix remaining CI/CD compilation errors - complete SRP refactoring
RyAuld 857f798
Fix NetCoreTestApp to use multi-tenant app from lab
RyAuld 2711a9f
Merge branch 'main' into labmigration
RyAuld 70813a4
Test: Change Interactive_AADAsync to use multi-tenant app
RyAuld 263fec3
Merge branch 'labmigration' of https://github.com/AzureAD/microsoft-aβ¦
RyAuld 62d15f6
Merge branch 'main' into labmigration
RyAuld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,11 @@ namespace Microsoft.Identity.Test.Integration.HeadlessTests | |
| [TestClass] | ||
| public class RegionalAuthIntegrationTests | ||
| { | ||
| // TODO: TENANT MIGRATION - These tests currently use original tenant configuration | ||
| // Regional endpoints (eastus2.login.microsoft.com) return AADSTS100007 with new tenant | ||
| // "Only managed identities and Microsoft internal service identities are supported" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ack. Let's have a list of these. We will talk to AAD to enable these features. |
||
| // Regional endpoints are restricted by Azure AD policy for regular app registrations | ||
|
|
||
| private KeyVaultSecretsProvider _keyVault; | ||
|
|
||
| private const string RegionalHost = "centralus.login.microsoft.com"; | ||
|
|
@@ -59,7 +64,7 @@ public async Task AcquireTokenToRegionalEndpointAsync(bool instanceDiscoveryEnab | |
| { | ||
| // Arrange | ||
| var factory = new HttpSnifferClientFactory(); | ||
| var settings = ConfidentialAppSettings.GetSettings(Cloud.Public); | ||
| var settings = ConfidentialAppSettings.GetSettings(Cloud.PublicLegacy); // Use legacy config for regional tests | ||
| settings.InstanceDiscoveryEndpoint = instanceDiscoveryEnabled; | ||
| _confidentialClientApplication = BuildCCA(settings, factory); | ||
|
|
||
|
|
@@ -78,7 +83,7 @@ public async Task InvalidRegion_GoesToInvalidAuthority_Async() | |
| { | ||
| // Arrange | ||
| var factory = new HttpSnifferClientFactory(); | ||
| var settings = ConfidentialAppSettings.GetSettings(Cloud.Public); | ||
| var settings = ConfidentialAppSettings.GetSettings(Cloud.PublicLegacy); // Use legacy config for regional tests | ||
| _confidentialClientApplication = BuildCCA(settings, factory, true, "invalid"); | ||
|
|
||
| Environment.SetEnvironmentVariable(TestConstants.RegionName, TestConstants.Region); | ||
|
|
@@ -131,7 +136,7 @@ private IConfidentialClientApplication BuildCCA( | |
| } | ||
| else | ||
| { | ||
| builder.WithCertificate(settings.GetCertificate()); | ||
| builder.WithCertificate(settings.Certificate); | ||
| } | ||
|
|
||
| builder.WithAuthority($@"https://{settings.Environment}/{settings.TenantId}") | ||
|
|
@@ -193,7 +198,7 @@ private static string GetSignedClientAssertionUsingMsalInternal(string clientId, | |
| var manager = PlatformProxyFactory.CreatePlatformProxy(null).CryptographyManager; | ||
|
|
||
| var jwtToken = new JsonWebToken(manager, clientId, TestConstants.ClientCredentialAudience, claims); | ||
| var cert = ConfidentialAppSettings.GetSettings(Cloud.Public).GetCertificate(); | ||
| var cert = ConfidentialAppSettings.GetSettings(Cloud.PublicLegacy).Certificate; // Use legacy config for regional tests | ||
|
|
||
| return jwtToken.Sign(cert, true, true); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for unit tests only I believe. Unit tests do not make HTTP calls to Entra and do not rely on an actual infra. I would recommend not modifying this.